nsGREGlue.cpp change breaks Solaris Studio 10 build

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: km, Assigned: dougt)

Tracking

({fixed1.8})

Trunk
Sun
Solaris
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9a1) Gecko/20050831 Firefox/1.6a1
Build Identifier: 

The changes in 1.12 broke the Solaris Studio 10 build over the definition of
INIClosure. The errors are:

"mozilla/xpcom/glue/nsGREGlue.cpp", line 448: Error: A class with a reference
member must have a user-defined constructor.
"mozilla/xpcom/glue/nsGREGlue.cpp", line 495: Error: Expected an expression.
"mozilla/xpcom/glue/nsGREGlue.cpp", line 501: Error: Use ";" to terminate
statements.
3 Error(s) detected.


Any suggestions? 

Reproducible: Always
(Reporter)

Updated

12 years ago
Component: Build → Build Config
Product: Webtools → Firefox

Updated

12 years ago
Assignee: cls → dougt
Status: UNCONFIRMED → NEW
Component: Build Config → XPCOM
Ever confirmed: true
Product: Firefox → Core
QA Contact: timeless → xpcom

Comment 1

12 years ago
*** Bug 307140 has been marked as a duplicate of this bug. ***

Comment 2

12 years ago
*** Bug 308107 has been marked as a duplicate of this bug. ***
*** Bug 308713 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 4

12 years ago
Created attachment 197445 [details] [diff] [review]
patch v.1
Attachment #197445 - Flags: review?(dbaron)

Comment 5

12 years ago
Comment on attachment 197445 [details] [diff] [review]
patch v.1

> GRE_GetPathFromConfigFile(const char* filename,
...
> {
>   nsINIParser parser;
>+  nsresult rv = parser->Init(filename);

Oops.  Wrong patch?
(Assignee)

Comment 6

12 years ago
Comment on attachment 197445 [details] [diff] [review]
patch v.1

wow.
Attachment #197445 - Flags: review?(dbaron) → review-
(Assignee)

Comment 7

12 years ago
Created attachment 197458 [details] [diff] [review]
patch v.2
Attachment #197445 - Attachment is obsolete: true
Attachment #197458 - Flags: review?(dbaron)

Comment 8

12 years ago
Shouldn't there be some code to actually initialize INIClosure::parser?  It
looks like you're missing changes to GRE_GetPathFromConfigFile.

Comment 9

12 years ago
(In reply to comment #7)
> Created an attachment (id=197458) [edit]
> patch v.2 

after appliing patch v.2:
...
"nsGREGlue.cpp", line 524: Error: Cannot use nsINIParser to initialize nsINIParser*.
...

Comment 10

12 years ago
(In reply to comment #9)

> after applying patch v.2:

and

% diff p2/nsGREGlue.cpp  p3/nsGREGlue.cpp
518,519c518,519
<   nsINIParser parser;
<   nsresult rv = parser.Init(filename);
---
>   nsINIParser *parser;
>   nsresult rv = parser->Init(filename);
531c531
<   parser.GetSections(CheckINIHeader, &c);
---
>   parser->GetSections(CheckINIHeader, &c);

the compiler (CC: Sun C++ 5.7 Patch 117830-03 2005/07/21) 
seems to be satisfied 8-)

Comment 11

12 years ago
(In reply to comment #10)
> (In reply to comment #9)
> 
> > after applying patch v.2:
> 
> and
> 
> % diff p2/nsGREGlue.cpp  p3/nsGREGlue.cpp
> 518,519c518,519
> <   nsINIParser parser;
> <   nsresult rv = parser.Init(filename);
> ---
> >   nsINIParser *parser;
> >   nsresult rv = parser->Init(filename);
> 531c531
> <   parser.GetSections(CheckINIHeader, &c);
> ---
> >   parser->GetSections(CheckINIHeader, &c);
> 
> the compiler (CC: Sun C++ 5.7 Patch 117830-03 2005/07/21) 
> seems to be satisfied 8-)


I ran into this same problem today and the above fixes seem to work
for both Studio 8 and Studio 10 compilers.


Attachment #197458 - Flags: review?(dbaron) → review+

Comment 12

12 years ago
(In reply to comment #10)
> >   nsINIParser *parser;
> >   nsresult rv = parser->Init(filename);
It is not correct.
"parser" here is just a pointer without initialise.

Comment 13

12 years ago
Created attachment 199044 [details] [diff] [review]
Patch v3

Updated

12 years ago
Attachment #199044 - Flags: review?(dbaron)
Attachment #199044 - Flags: review?(dbaron) → review+

Updated

12 years ago
Attachment #199044 - Flags: superreview?(darin)

Comment 14

12 years ago
(In reply to comment #13)
> Created an attachment (id=199044) [edit]
> Patch v3

Patch v3 is OK for the compiler mentioned above :-)

Comment 15

12 years ago
*** Bug 311924 has been marked as a duplicate of this bug. ***

Comment 16

12 years ago
(In reply to comment #15)
> *** Bug 311924 has been marked as a duplicate of this bug. ***

Argh! One of these days I'll learn how to query :/

Anyway, patch v3 works fine for me. Thanks!

Comment 17

12 years ago
(In reply to comment #16)

> Argh! One of these days I'll learn how to query :/

But that's hard work to learn ;).

> Anyway, patch v3 works fine for me. Thanks!

Works fine for me too.
(Assignee)

Comment 18

12 years ago
Checking in nsGREGlue.cpp;
/cvsroot/mozilla/xpcom/glue/nsGREGlue.cpp,v  <--  nsGREGlue.cpp
new revision: 1.15; previous revision: 1.14
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 19

12 years ago
Should get this on 1.8branch as well.
Flags: blocking1.8rc1?

Updated

12 years ago
Attachment #199044 - Flags: superreview?(darin) → approval1.8rc1?

Updated

12 years ago
Attachment #199044 - Flags: approval1.8rc1? → approval1.8rc1+

Comment 20

12 years ago
fixed1.8
Keywords: fixed1.8

Comment 21

12 years ago
belated flag cleanup
Flags: blocking1.8rc1?

Comment 22

12 years ago
*** Bug 312996 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.