307076 - Menus on WYSIWYG editors open on wrong place.

Status: VERIFIED FIXED

(Core :: Layout: Positioned, defect)

Description

[Pardal Freudenthal (:ShareBird)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050904 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050904 Firefox/1.0+

Posting on topics from http://www.dslteam.de/forum/ using the WYSIWYG editor and
trying to edit the font type makes the menu open on a wrong place (only visible
if I scroll the page)

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.dslteam.de/forum/ . You will need an account to be able to
post. You can use Bugmenot for it:
http://bugmenot.com/view.php?url=http%3A%2F%2Fdslteam.de
2. Go to any forum and try to open a new topic clicking on "Neues Thema" button.
3. On the WYSIWYG Editor try to change font type or font size by clicking on the
menu.
4. Apparently it doesn't open.
5. Scroll the page and you will see the menu under the whole editor.

Actual Results:  
The menu opens on the wrong place.

Expected Results:  
Menu opens directly under the scrollbox.

Comment 1

[Pardal Freudenthal (:ShareBird)]

Attachment: Picture showing the bug

Comment 2

[Martijn Wargers (dead)]

Attachment: not minimal testcase

I think it is because the containing table cell has position:relative;
Position:relative doesn't work in Mozilla1.7, but seems to work now in current
trunk builds.
When removing that style rule, the menu gets on the right place.
So I think this is a tech evangelism issue.

Comment 3

[Martijn Wargers (dead)]

Hmm, position:relative is still not working on table cells, so that can't be it
(strange that it makes the difference here, then).
Anyway, I still think this is probably tech evangelism, but a minimal testcase
is needed for that.

Comment 4

[Pardal Freudenthal (:ShareBird)]

As additional information, it works fine with Firefox 1.0.4.

Comment 5

[Pardal Freudenthal (:ShareBird)]

I was able to point a regression date. It works fine with 2005-03-21 build but
stopped to work on 2005-03-22. On 2005-03-22 it's also impossible to put any
text on textbox. This issue was solved on 2005-04-06, but it started the issue
on scrollbox menu.

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase

Ok, this is a minimal testcase.
The behavior for the red bordered popup changed, but it changed in fact for the
better.
The green bordered popup still shows the old, wrong behavior.

So the WYSIWYG editor relies on the fact that td style="position:relative"
doesn't work.

But I think this is not good behavior, both popups should at least act the
same.

Comment 7

[Martijn Wargers (dead)]

Thanks Pardal!
When looking at the regression range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-21+05%3A00%3A00&maxdate=2005-03-22+10%3A00%3A00&cvsroot=%2Fcvsroot
The only bug that could have caused this seems bug 282754.

Comment 8

[Martijn Wargers (dead)]

Robert, you might want to take a look at this bug. Maybe it is something that
needs to be fixed for the 1.8 branch.

Comment 9

[Asa Dotzler [:asa]]

->roc

Comment 10

[Asa Dotzler [:asa]]

dbaron, can you look into this regression?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm pretty sure this is nsCSSFrameConstructor being inconsistent: it's probably
not pushing an absolute containing block for rel-pos table cells, but it is
probably finding an absolute containing block when we dynamically create the frame.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Be more consistent ... no table-related frames push absolute containing blocks
so we shouldn't treat them as abs containing blocks.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 198046 [details] [diff] [review]
fix

Looks ok, but we should make sure we fix this as we fix other issues (eg if we
make table caption construction use ConstructBlock).

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in to trunk.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 198046 [details] [diff] [review]
fix

need approval for this blocker bug

Comment 16

[Scott MacGregor]

Comment on attachment 198046 [details] [diff] [review]
fix

approving for the branch. Thanks roc.

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in on branch.

Comment 18

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050930
Firefox/1.6a1 ID:2005093016

Looks good to me.

Comment 19

[Boris Zbarsky [:bzbarsky]]

Pushed a testcase: http://hg.mozilla.org/mozilla-central/rev/df1c424265ab