Closed Bug 307142 Opened 17 years ago Closed 17 years ago

strict JS error in phishingDetector.js

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

()

Details

(Keywords: fixed-seamonkey1.1a, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Line 108 of phishingDetector.js gives a strict JS error, hrefURL is not declared.
Attached patch Simple patch v0.1 (obsolete) — Splinter Review
This patch:
* Declares hrefURL
Assignee: mail → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #194956 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 194956 [details] [diff] [review]
Simple patch v0.1

>-  hrefURL  = ioService.newURI(href, null, null);
>+  var hrefURL  = ioService.newURI(href, null, null);
Nit: fix the doubled space before = while you're at it.
Attachment #194956 - Flags: review?(neil.parkwaycc.co.uk) → review+
Changes since v0.1:
* Removed extra space from before =

Carrying forward r= and requesting sr=
Attachment #194956 - Attachment is obsolete: true
Attachment #194964 - Flags: superreview?(bienvenu)
Attachment #194964 - Flags: review+
Attachment #194964 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 194964 [details] [diff] [review]
Tweaked patch v0.1a (Checked in on trunk and MOZILLA_1_8_BRANCH)

Checking in
phishingDetector.js;
new revision: 1.3; previous revision: 1.2
done
Attachment #194964 - Attachment description: Tweaked patch v0.1a → Tweaked patch v0.1a (Checked in)
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Comment on attachment 194964 [details] [diff] [review]
Tweaked patch v0.1a (Checked in on trunk and MOZILLA_1_8_BRANCH)

See bug 343059.
Attachment #194964 - Flags: approval-seamonkey1.1a?
Comment on attachment 194964 [details] [diff] [review]
Tweaked patch v0.1a (Checked in on trunk and MOZILLA_1_8_BRANCH)

a=me for 1.1
Attachment #194964 - Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Attachment #194964 - Attachment description: Tweaked patch v0.1a (Checked in) → Tweaked patch v0.1a (Checked in on trunk and MOZILLA_1_8_BRANCH)
Comment on attachment 194964 [details] [diff] [review]
Tweaked patch v0.1a (Checked in on trunk and MOZILLA_1_8_BRANCH)

Checkin: {
2006-07-12 13:05	mnyromyr%tprac.de 	mozilla/mailnews/base/resources/content/phishingDetector.js 	1.1.2.5 	MOZILLA_1_8_BRANCH
}
(In reply to comment #7)
> Checkin: {
...
Actually, I consider such comments bugspam, hence I don't do it.
I rather mark the *patch* as being checked in, so you can see its state by looking at the patch without grepping through gazillions of comments...
You need to log in before you can comment on or make changes to this bug.