307148 - Build error in viewer (JSConsole.cpp)

Status: RESOLVED DUPLICATE of bug 308331

(Core :: DOM: Navigation, defect)

Description

[rbs]

I had to explicitly --disable-tests in .mozconfig to get the build.

Building deps for JSConsole.cpp
/cygdrive/d/Mozilla/tip/mozilla/build/cygwin-wrapper cl -FoJSConsole.obj -c  -DM
OZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.0\" -DOSARCH=\"WINNT\" -DBUILD_ID=00000000
00 -DUSE_LOCAL_WIDGETS  -I../../../dist/include/xpcom -I../../../dist/include/st
ring -I../../../dist/include/embed_base -I../../../dist/include/webshell -I../..
/../dist/include/widget -I../../../dist/include/gfx -I../../../dist/include/layo
ut -I../../../dist/include/content -I../../../dist/include/dom -I../../../dist/i
nclude/webbrwsr -I../../../dist/include/docshell -I../../../dist/include/util -I
../../../dist/include/uriloader -I../../../dist/include/locale -I../../../dist/i
nclude/necko -I../../../dist/include/htmlparser -I../../../dist/include/view -I.
./../../dist/include/pref -I../../../dist/include/intl -I../../../dist/include/u
nicharutil -I../../../dist/include/editor -I../../../dist/include/windowwatcher
-I../../../dist/include/xpconnect -I../../../dist/include/js -I../../../dist/inc
lude/webshell_tests -I../../../dist/include -I../../../dist/include/nspr    -I/u
sr/X11R6/include     -I/usr/X11R6/include -TP -nologo -W3 -Gy -FdJSConsole.pdb
-DDEBUG -D_DEBUG -DDEBUG_rbs -DTRACING -Zi -DWIDGET_DLL=\"libwidget_windows.dll\
" -DGFXWIN_DLL=\"libgfx_windows.dll\"  -MDd          -I/usr/X11R6/include -DMOZI
LLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -
D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -DWINVER=0x400 -D_WIN
32_WINNT=0x400 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD
_INO=d_ino -DMOZ_DEFAULT_TOOLKIT=\"windows\" -DMOZ_SUITE=1 -DMOZ_BUILD_APP=suite
 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -
DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1 -DMOZ_MATHML=1 -
DMOZ_UPDATE_CHANNEL=default -DMOZ_LOGGING=1 -DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER
_DIR=\"Mozilla\" -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".dll\" -D
JS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZ_REFLOW_PERF=1 -DMOZ_R
EFLOW_PERF_DSP=1 -DMOZILLA_LOCALE_VERSION=\"1.8b2\" -DMOZILLA_REGION_VERSION=\"1
.8b2\" -DMOZILLA_SKIN_VERSION=\"1.5\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cy
gdrive/d/Mozilla/tip/mozilla/webshell/tests/viewer/JSConsole.cpp
JSConsole.cpp
../../../dist/include/js\jspubtd.h(52) : error C2146: syntax error : missing ';'
 before identifier 'jsint'
../../../dist/include/js\jspubtd.h(52) : fatal error C1004: unexpected end of fi
le found
make[4]: *** [JSConsole.obj] Error 2
make[4]: Leaving directory `/cygdrive/d/Mozilla/tip/mozilla/webshell/tests/viewe
r'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/cygdrive/d/Mozilla/tip/mozilla/webshell/tests'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/cygdrive/d/Mozilla/tip/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/cygdrive/d/Mozilla/tip/mozilla'
make: *** [build] Error 2

Comment 1

[cls]

The win32 tinderboxes build with tests enabled and they're fine.  What version
of MSVC are you using?

Comment 2

[Boying Lu]

I saw this error also and I use vc6.0 with vc6sp5 and vcpp5 added.

Comment 3

[Boying Lu]

The problem is gone if "--disable-tests" is added

Comment 4

[John Gaunt (redfive)]

This is keeping me from building _anything_ recently. I'm building on WinXP and
Win2k, both with MSVC 6 with the proccesor pack and the patch. It seems bad to
me to have to turn off tests in order to build, doesn't that defeat the purpose
of the tests?

cls: could the tinderboxen have something cached that is keeping this error from
popping up?

Since Adam is not reading bugmail should this get assigned to someone else?

Comment 5

[John Gaunt (redfive)]

Looks like we've tracked it down to
http://lxr.mozilla.org/seamonkey/source/nsprpub/pr/include/obsolete/protypes.h#155

I can add |typedef long int32| here after line 160 and I get
webshell/tests/viewer/ to compile.

Can't say yet why this popped up all of a sudden,  or why the tinderboxen aren't
having this issue. winsock.h and winsock2.h don't actually appear to be
declaring an int32 but perhaps something in the Windows SDK does (the seamonkey
tinderbox creature has the windows SDK in its Include path ahead of the MSVC paths).

Comment 6

[timeless]

the problem is that redfive is targetting winnt5 which means he gets winsock2, 
i target winnt4, so windows.h pulls in winsock.

as i finally chased down the problem, nspr is protecting against winsock2.1 
(msvc4.2, maybe msvc5) where the people here with the problem (and the people 
here who won't have the problem until they foolishly decide to target nt5) all 
have winsock2.2 which doesn't have the typedef but which still causes nspr to 
supress generating int32.

*** This bug has been marked as a duplicate of 308331 ***