Closed Bug 307249 Opened 15 years ago Closed 15 years ago

Changing attrs on <input> calls AfterSetAttr too many times

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: allan)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file)

It looks like the patch for bug 84400 didn't remove the AfterSetAttr calls in
the SetAttr/UnsetAttr overrides in this class....
Blocks: 84400
Depends on: 308270
Attached patch PatchSplinter Review
(In reply to comment #0)
> It looks like the patch for bug 84400 didn't remove the AfterSetAttr calls in

> the SetAttr/UnsetAttr overrides in this class....

I managed to mis-read that a lot of times, dunno why, but now I get it. Here's
a patch that removes the calls to AfterSetAttr() in nsHTMLInputElement.

This should be it for :enabled/:disabled, and we can push it to branch?

(sorry for the delay... jetlag and other bad excuses)
Attachment #197030 - Flags: superreview?(bzbarsky)
Attachment #197030 - Flags: review?(bzbarsky)
Comment on attachment 197030 [details] [diff] [review]
Patch

r+sr=bzbarsky
Attachment #197030 - Flags: superreview?(bzbarsky)
Attachment #197030 - Flags: superreview+
Attachment #197030 - Flags: review?(bzbarsky)
Attachment #197030 - Flags: review+
Checked in on trunk
Status: NEW → ASSIGNED
Attachment #197030 - Flags: approval1.8b5?
Comment on attachment 197030 [details] [diff] [review]
Patch

a=bzbarsky for 1.8b5, since bug 84400 already landed there....
Attachment #197030 - Flags: approval1.8b5? → approval1.8b5+
Checked in on 1.8 branch
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.