Changing attrs on <input> calls AfterSetAttr too many times

RESOLVED FIXED

Status

()

--
major
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: bzbarsky, Assigned: allan)

Tracking

({fixed1.8})

Trunk
x86
Linux
fixed1.8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
It looks like the patch for bug 84400 didn't remove the AfterSetAttr calls in
the SetAttr/UnsetAttr overrides in this class....
(Reporter)

Updated

13 years ago
Blocks: 84400
(Reporter)

Updated

13 years ago
Depends on: 308270
(Assignee)

Comment 1

13 years ago
Created attachment 197030 [details] [diff] [review]
Patch

(In reply to comment #0)
> It looks like the patch for bug 84400 didn't remove the AfterSetAttr calls in

> the SetAttr/UnsetAttr overrides in this class....

I managed to mis-read that a lot of times, dunno why, but now I get it. Here's
a patch that removes the calls to AfterSetAttr() in nsHTMLInputElement.

This should be it for :enabled/:disabled, and we can push it to branch?

(sorry for the delay... jetlag and other bad excuses)
Attachment #197030 - Flags: superreview?(bzbarsky)
Attachment #197030 - Flags: review?(bzbarsky)
(Reporter)

Comment 2

13 years ago
Comment on attachment 197030 [details] [diff] [review]
Patch

r+sr=bzbarsky
Attachment #197030 - Flags: superreview?(bzbarsky)
Attachment #197030 - Flags: superreview+
Attachment #197030 - Flags: review?(bzbarsky)
Attachment #197030 - Flags: review+
(Assignee)

Comment 3

13 years ago
Checked in on trunk
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Attachment #197030 - Flags: approval1.8b5?
(Reporter)

Comment 4

13 years ago
Comment on attachment 197030 [details] [diff] [review]
Patch

a=bzbarsky for 1.8b5, since bug 84400 already landed there....
Attachment #197030 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 5

13 years ago
Checked in on 1.8 branch
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.