307418 - Fails to build on arm with gcc4

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8b4) Gecko/20050907 Debian/1.4.99+1.5alpha-2 Firefox/1.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8b4) Gecko/20050907 Debian/1.4.99+1.5alpha-2 Firefox/1.4

Copy/Paste from http://bugs.debian.org/325535 :
"The current mozilla package fails to build on alpha, arm, and ia64
because it uses __attribute__((unused)) to mark static functions that
are called only from assembly routines.  As of gcc 3.1,
__attribute__((used)) exists for marking static functions that are used;
as of gcc 4.0, __attribute__((unused)) still suppresses compiler
warnings about unused static functions, but it does *not* prevent the
compiler from optimizing them away."

While this has been fixed for alpha and ia64 in mozilla 1.8 branch at least,
there is still one problem with arm for which I'm attaching a patch.

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch for the issue on arm

Comment 2

[Brendan Eich [:brendan]]

Porting fix, should get in for 1.8b5.

/be

Comment 3

[Doug Turner (:dougt)]

Happy to check this in.  However, I am wondering about support for gcc 2.95.  Is
this completely dead for embedders?

Comment 4

[timeless]

certain platforms are stuck w/ gcc2.95 i hope someone isn't working on breaking 
them.

Comment 5

[Doug Turner (:dougt)]

Mike, any other workarounds possible?  a 2.95 #ifdef or something?

Comment 6

[Mike Hommey [:glandium]]

I think it woudn't fail on gcc 2.95 but I could be wrong. Since I don't have an
arm around here, could someone of you guys actually check ? Thanks

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 195178 [details] [diff] [review]
Patch for the issue on arm

r+sr=shaver

Comment 8

[Scott MacGregor]

Comment on attachment 195178 [details] [diff] [review]
Patch for the issue on arm

this needs to get fixe don the trunk for verification first.

Comment 9

[Scott MacGregor]

Doug, is this patch ready to land? time is running short and this is likely to
get taken off the radar if it doesn't get in soon. Thanks. 

Comment 10

[Doug Turner (:dougt)]

sure, lets land it on the trunk first.  I am not sure how important this is for
1.8b5.

Checking in xptcstubs_arm.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp,v  <-- 
xptcstubs_arm.cpp
new revision: 1.8; previous revision: 1.7
done

Comment 11

[Boris Zbarsky [:bzbarsky]]

So is this fixed?  The patch was checked in, right?

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 356609 has been marked as a duplicate of this bug. ***

Comment 13

[timeless]

i'm going to resolve this as fixed because while it probably didn't fix things and i'm grumbling i'd rather bugs that have caused changes to cvs have fixed associated with them.

note that i'm the module owner for this mess at this time, so consider this a form of disgruntled house cleaning.