307478 - Build failure with syntax error in nsDebug.h

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rupesh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: 

Tinder box build on AIX fails with the below error from 31st Aug, 10:52 AM.

/trunk/mozilla/xpcom/glue/nsDebug.h", line 219.1: 1506-046 (S) Syntax error.
gmake[1]: *** [pldhash.o] Error 1
gmake[1]: Leaving directory `/trunk/mozilla/obj-opt/xpcom/glue'
gmake: *** [all] Error 2


Reproducible: Always

Comment 1

[Rupesh]

Attachment: Proposed patch

Changing C++ comment style to C comment style resolves the issue.

Comment 2

[Philip K. Warren]

Fix checked in on trunk. Leaving bug open in order to fix this on the branch as
well.

Checking in nsDebug.h;
/cvsroot/mozilla/xpcom/glue/nsDebug.h,v  <--  nsDebug.h
new revision: 1.22; previous revision: 1.21
done

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

pldhash.c shouldn't include nsDebug.h, which is a C++ header.  It ought to be
able to include prlog.h if all it needs is PR_ASSERT.

Comment 4

[Benjamin Smedberg]

nsDebug.h is no longer a C++ header, and this code was expcitly introduced to
avoid the NSPR dependency. See bug 306334.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yikes, and it still uses the very C++-ish (for our tree) inter-caps filename?

Comment 6

[Benjamin Smedberg]

pwk, can you get this landed on branch also?

Comment 7

[Philip K. Warren]

(In reply to comment #6)
> pwk, can you get this landed on branch also?

I may not have a chance to get this landed for a couple of days.

Comment 8

[Scott MacGregor]

this needs to get landed on the branch ASAP or it may not make it into the next
release.

Comment 9

[Benjamin Smedberg]

Fixed on the 1.8 branch.