User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2 Build Identifier: Tinder box build on AIX fails with the below error from 31st Aug, 10:52 AM. /trunk/mozilla/xpcom/glue/nsDebug.h", line 219.1: 1506-046 (S) Syntax error. gmake: *** [pldhash.o] Error 1 gmake: Leaving directory `/trunk/mozilla/obj-opt/xpcom/glue' gmake: *** [all] Error 2 Reproducible: Always
Created attachment 195249 [details] [diff] [review] Proposed patch Changing C++ comment style to C comment style resolves the issue.
Fix checked in on trunk. Leaving bug open in order to fix this on the branch as well. Checking in nsDebug.h; /cvsroot/mozilla/xpcom/glue/nsDebug.h,v <-- nsDebug.h new revision: 1.22; previous revision: 1.21 done
pldhash.c shouldn't include nsDebug.h, which is a C++ header. It ought to be able to include prlog.h if all it needs is PR_ASSERT.
nsDebug.h is no longer a C++ header, and this code was expcitly introduced to avoid the NSPR dependency. See bug 306334.
Yikes, and it still uses the very C++-ish (for our tree) inter-caps filename?
pwk, can you get this landed on branch also?
(In reply to comment #6) > pwk, can you get this landed on branch also? I may not have a chance to get this landed for a couple of days.
this needs to get landed on the branch ASAP or it may not make it into the next release.
Fixed on the 1.8 branch.