Build failure with syntax error in nsDebug.h

RESOLVED FIXED in mozilla1.8beta4

Status

()

Core
XPCOM
--
blocker
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Rupesh, Assigned: Rupesh)

Tracking

({fixed1.8})

Trunk
mozilla1.8beta4
x86
Other
fixed1.8
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: 

Tinder box build on AIX fails with the below error from 31st Aug, 10:52 AM.

/trunk/mozilla/xpcom/glue/nsDebug.h", line 219.1: 1506-046 (S) Syntax error.
gmake[1]: *** [pldhash.o] Error 1
gmake[1]: Leaving directory `/trunk/mozilla/obj-opt/xpcom/glue'
gmake: *** [all] Error 2


Reproducible: Always
(Assignee)

Comment 1

12 years ago
Created attachment 195249 [details] [diff] [review]
Proposed patch

Changing C++ comment style to C comment style resolves the issue.
Attachment #195249 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #195249 - Flags: review+
Attachment #195249 - Flags: approval1.8b5?
Assignee: nobody → trupesh
Component: Build Config → XPCOM
Product: Mozilla Application Suite → Core
Target Milestone: --- → mozilla1.8beta4
Version: unspecified → Trunk

Comment 2

12 years ago
Fix checked in on trunk. Leaving bug open in order to fix this on the branch as
well.

Checking in nsDebug.h;
/cvsroot/mozilla/xpcom/glue/nsDebug.h,v  <--  nsDebug.h
new revision: 1.22; previous revision: 1.21
done
Status: NEW → ASSIGNED

Updated

12 years ago
QA Contact: build-config → xpcom
pldhash.c shouldn't include nsDebug.h, which is a C++ header.  It ought to be
able to include prlog.h if all it needs is PR_ASSERT.
nsDebug.h is no longer a C++ header, and this code was expcitly introduced to
avoid the NSPR dependency. See bug 306334.
Yikes, and it still uses the very C++-ish (for our tree) inter-caps filename?

Updated

12 years ago
Attachment #195249 - Flags: approval1.8b5? → approval1.8b5+
pwk, can you get this landed on branch also?
Flags: blocking1.8b5+

Comment 7

12 years ago
(In reply to comment #6)
> pwk, can you get this landed on branch also?

I may not have a chance to get this landed for a couple of days.

Comment 8

12 years ago
this needs to get landed on the branch ASAP or it may not make it into the next
release.
Fixed on the 1.8 branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.