Closed Bug 307593 Opened 19 years ago Closed 19 years ago

Remove unused and broken template class |CWordTokenizer|

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: engel, Assigned: engel)

References

Details

Attachments

(1 file)

Remove template class |CWordTokenizer|
4.82 KB, patch
mrbkap
: review+
jst
: superreview+
Details | Diff | Splinter Review
Currently, the template class |CWordTokenizer| is broken (Bug 104479). However, since it is never used anyway, it should be removed.
Note that it is suggested to maybe use it for parsing the XML declaration. Because this code is somewhat optimized and is only ~70 lines in total, probably not much overall clarity would be gained by using a working implementation of |CWordTokenizer| which requires ~120 lines. So even if |CWordTokenizer| would be fixed, it would not be very useful in the current code.
Status: NEW → ASSIGNED
Assignee: parser → Hans-A.Engel
Attachment #195338 - Flags: review?(mrbkap)
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 195338 [details] [diff] [review] Remove template class |CWordTokenizer| Off with its head! r=mrbkap
Attachment #195338 - Flags: review?(mrbkap) → review+
Attachment #195338 - Flags: superreview?(jst)
Comment on attachment 195338 [details] [diff] [review] Remove template class |CWordTokenizer| sr=jst
Attachment #195338 - Flags: superreview?(jst) → superreview+
I took the liberty of checking this patch in. Marking this bug as FIXED. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified via LXR and Bonsai (source-code validation).
Status: RESOLVED → VERIFIED
Blocks: 313038
No longer blocks: 313038
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: