Note: There are a few cases of duplicates in user autocompletion which are being worked on.

mac l10n repackaging broken on 1.8 branch

RESOLVED FIXED in mozilla1.8alpha5

Status

()

Core
Build Config
--
blocker
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Pike, Assigned: Mark Mentovai)

Tracking

({fixed1.8})

1.8 Branch
mozilla1.8alpha5
PowerPC
Mac OS X
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
We don't have current mac builds, as the repackaging collapsed again.

MacOSX Darwin 7.9.0 maya Clbr Fx-Release didn't build for quite some time,
I guess the yellow on 
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8-l10n&hours=24&maxdate=1126210526&legend=0

broke it.
Assignee: dbaron → chase
(Assignee)

Comment 1

12 years ago
Created attachment 195446 [details] [diff] [review]
fix

In order to extract the license from the dmg, we:
 - unflatten it, putting the license in a resource fork
 - run DeRez, to slurp the license resources out
 - flatten it again, hopefully restoring the dmg to its original state

Read-only/read-write only applies to the filesystem within the dmg.  This (and
only this) part of the unpackaging deals with the file directly.  This process
should leave the "in" dmg in exactly the same state that it was discovered, and
I've never seen it ruin the file, but that's what's happening here.

So, we can change the process above to:
 - copy the "in" dmg to a temporary location
 - unflatten it, putting the license in a resource fork
 - run DeRez, to slurp the license resources out
 - remove the "in" dmg
Assignee: chase → mark
Status: NEW → ASSIGNED
Attachment #195446 - Flags: review?(chase)
(Assignee)

Comment 2

12 years ago
(In reply to comment #1)
>  - remove the "in" dmg

The temporary one, I mean.

Updated

12 years ago
Attachment #195446 - Flags: review?(chase) → review+
(Assignee)

Updated

12 years ago
Component: Tinderbox Configuration → Build Config
Product: mozilla.org → Core
Target Milestone: --- → mozilla1.8alpha5
Version: other → 1.8 Branch
(Assignee)

Updated

12 years ago
Attachment #195446 - Flags: approval1.8b5?
(Assignee)

Updated

12 years ago
Flags: blocking1.8b5?
(Assignee)

Comment 3

12 years ago
Checked in on the trunk.  Will hit the branch when it opens.  No official
localized Mac Firefox 1.5b1s, tough luck.

Note that trunk Firefox l10n repackaging is failing for a different reason: maya
is configured with --enable-official-branding and is looking for Firefox.app,
but atlantia is using generic branding, providing DeerPark.app.

Updated

12 years ago
Attachment #195446 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 4

12 years ago
Checked in, branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Flags: blocking1.8b5?
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 5

12 years ago
We've got new Mac l10n builds in
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8-l10n/.
 Fix is verified.
You need to log in before you can comment on or make changes to this bug.