Closed Bug 307734 Opened 19 years ago Closed 19 years ago

Some plugins result in truncated accessible page content

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access, fixed1.8)

Attachments

(1 file)

Two problems with how we expose plugins:
1) Windowless plugins with MSAA content are not exposed
2) Gecko content after the plugin is getting cut off, because the plugin doesn't
point back into Gecko content for IAccessible::get_accNextSibling()
Attachment #195430 - Flags: review?(parente) → review+
Attachment #195430 - Flags: superreview?(jst)
Flags: blocking1.8b5?
Severity: normal → critical
Summary: Plugin accessibility fixes → Some plugins result in truncated accessible page content
Flags: blocking1.8b5? → blocking1.8b5+
Comment on attachment 195430 [details] [diff] [review]
1) Have an object to own the native plugin placeholder accessible, which knows its place in the Gecko tree, 2) Only use first child window for plugin if it exists

-In nsHTMLWin32ObjectOwnerAccessible::GetChildCount():

+  nsCOMPtr<nsIAccessible> onlyChild;
+  GetFirstChild(getter_AddRefs(onlyChild));
+  *aChildCount = (onlyChild != nsnull);

This does the right thing, but it's a bit odd to assign a boolean value into a
count (int) variable. Maybe change that to *aChildCount = (onlyChild == nsnull)
? 0 : 1; to make what's going on here a bit more explicit?

sr=jst
Attachment #195430 - Flags: superreview?(jst) → superreview+
Attachment #195430 - Flags: approval1.8b5?
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #195430 - Flags: approval1.8b5? → approval1.8b5+
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: