Some plugins result in truncated accessible page content

RESOLVED FIXED

Status

()

Core
Disability Access APIs
--
critical
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, fixed1.8, sec508})

Trunk
x86
Windows XP
access, fixed1.8, sec508
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Two problems with how we expose plugins:
1) Windowless plugins with MSAA content are not exposed
2) Gecko content after the plugin is getting cut off, because the plugin doesn't
point back into Gecko content for IAccessible::get_accNextSibling()
(Assignee)

Comment 1

12 years ago
Created attachment 195430 [details] [diff] [review]
1) Have an object to own the native plugin placeholder accessible, which knows its place in the Gecko tree, 2) Only use first child window for plugin if it exists
Attachment #195430 - Flags: review?(parente)

Updated

12 years ago
Attachment #195430 - Flags: review?(parente) → review+
(Assignee)

Updated

12 years ago
Attachment #195430 - Flags: superreview?(jst)
(Assignee)

Updated

12 years ago
Flags: blocking1.8b5?
(Assignee)

Updated

12 years ago
Severity: normal → critical
Summary: Plugin accessibility fixes → Some plugins result in truncated accessible page content

Updated

12 years ago
Flags: blocking1.8b5? → blocking1.8b5+
Comment on attachment 195430 [details] [diff] [review]
1) Have an object to own the native plugin placeholder accessible, which knows its place in the Gecko tree, 2) Only use first child window for plugin if it exists

-In nsHTMLWin32ObjectOwnerAccessible::GetChildCount():

+  nsCOMPtr<nsIAccessible> onlyChild;
+  GetFirstChild(getter_AddRefs(onlyChild));
+  *aChildCount = (onlyChild != nsnull);

This does the right thing, but it's a bit odd to assign a boolean value into a
count (int) variable. Maybe change that to *aChildCount = (onlyChild == nsnull)
? 0 : 1; to make what's going on here a bit more explicit?

sr=jst
Attachment #195430 - Flags: superreview?(jst) → superreview+
(Assignee)

Updated

12 years ago
Attachment #195430 - Flags: approval1.8b5?
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #195430 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Updated

12 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.