307749 - sunbird build implicitly generates calendar .xpi also

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This is causing (indirectly) the Mac Tinderbox bustage.  It seems to me that it
makes more sense to have separate explicit targets for calendar.xpi and Sunbird,
probably controlled by explicit mozconfig file options.  This way it would be
possible to specify building either or both the xpi and Sunbird.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

This also breaks other architectures like x86-64 because some components gets compiled without -fPIC in static builds while the XPI build requires dynamic libs.
This could be fixed by using FORCE_USE_PIC=1 but it would be cleaner to resolve this bug IMHO.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Why it is needed at all to build the XPI in a sunbird build?
I think it can simply be avoided? If one really needs an XPI it can be built by make -C ...

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

As we have the static/dynamic problem and sunbird's calendar.jar is anyway different from the default one I would suggest to avoid building the XPI along with sunbird.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 202344 [details] [diff] [review]
patch

r=mvl

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Fixed; thanks for the patch, Wolfgang.