307756 - <input type="image"> with -moz-user-input:none/disabled still processes events

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mats Palmgren (inactive)]

<input type="image"> with -moz-user-input:none/disabled still processes events
when replaced by ALT text.

STEPS TO REPRODUCE
1. load the attached testcase
2. click on the text

ACTUAL RESULTS
The form is submitted

EXPECTED RESULTS
Same as when the image is shown - i.e. no event processing

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Use the primary frame if no nsIFormControlFrame can be found for type="image"
for testing '-moz-user-input'.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 195441 [details] [diff] [review]
Patch rev. 1

Why are we even bothering with GetFormControlFrame when all we want is the
primary frame?

Comment 4

[Mats Palmgren (inactive)]

There is some special handling here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/html/content/src/nsGenericHTMLElement.cpp&rev=1.606&root=/cvsroot&mark=2275-2276#2261
I wasn't sure what that meant for the style context...

Comment 5

[Boris Zbarsky [:bzbarsky]]

That handling is really not an issue anymore, since we no longer support
:before/:after on replaced elements...  If we ever add back support, we'll have
to audit all out GetPrimaryFrameFor() calls anyway.

Comment 6

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Comment 7

[Mats Palmgren (inactive)]

Checked in to trunk at 2005-09-10 04:02 PDT

-> FIXED