26.96 KB, text/plain
245 bytes, text/html
1.26 KB, patch
Mike Schroepfer: approval1.8.1+
|Details | Diff | Splinter Review|
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050908 Firefox/1.6a1 Filing as security-sensitive because the testcase includes code from bug 306939 and I didn't manage to make a simplified testcase.
Created attachment 195480 [details] testcase (not reduced) Crashes while the status bar counter says 1411.
Created attachment 198651 [details] [diff] [review] Proposed fix The nsGrid::GetScrolledBox will happily return non-boxes if it's passed one, but if it gets a scrollframe for a non-box it'll return null. So we need to guard against it here. Or change what nsGrid::GetScrolledBox does.
Any reason not to take this safe fix on the 1.8/1.8.0 branches?
Main reason is that I have no idea what this code really does and what the implications of this change really are...
DBaron - any thoughts on risk for 1.8 branch?
Minusing for 220.127.116.11 based on Boris's discomfort (might be trading a safe null-deref for a worse crash elsewhere). We'll do more testing on the trunk and see if this can go into 18.104.22.168 safely.
DBaron/Bz any thoughts for 1.8.1? If we are going to take this for 22.214.171.124 we'll need it for 1.8.1 as well..
Boris: I'm pretty happy with this patch. The code being changed is determining if the child's layout manager is an nsIGridPart. If it's not a box at all, then it's certainly doesn't have an nsIGridPart layout manager (nsFrame's box code is nothing like an nsIGridPart). So it seems quite safe to me. Are you still concerned with the patch?
No, as long as someone understands why this is generally the right thing to do, I'm happy.
Comment on attachment 198651 [details] [diff] [review] Proposed fix a=schrep for 181drivers.
Checked in to MOZILLA_1_8_BRANCH.
Restoring lost blocking flag
Comment on attachment 198651 [details] [diff] [review] Proposed fix approved for 1.8.0 branch, a=dveditz for drivers
Fixed on 1.8.0 branch for 126.96.36.199.
v.fixed on 1.8.0 branch with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:188.8.131.52pre) Gecko/20061020 Firefox/184.108.40.206pre, no crash with reduced testcase.