307832 - Consider storing the string length in atoms

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Boris Zbarsky [:bzbarsky]]

With bug 307601 fixed (by attachment 172366 [details] [diff] [review]), the single most time consuming
part of nsIAtom::Equals(AString) is the strlen on the atom's char* needed to
create the dependent string.

Would it perhaps make sense to store the string length in atoms so that it can
just be passed in when we create the dependent string?

Comment 1

[Boris Zbarsky [:bzbarsky]]

For that matter, would it make sense to use an nsStringBuffer* instead of a char* in atoms?  That will make all atoms 8 bytes bigger, but maybe that's ok.  I guess since it's a char* buffer, not PRUnichar*, there's not much win to the Unicode ToString from this, though...

Comment 2

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jonas, didn't bug 534136 just fix all this?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This was fixed a long time ago