307949 - Firefox 1.5 BETA 1: "gContextMenu.linkURL()" seems to have been broken when called from extensions

Status: RESOLVED WONTFIX

(Firefox :: Menus, defect)

Description

[Alexander M Beedie]

User-Agent:       Opera/8.10 (Windows NT 5.1; U; en)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

in earlier builds of firefox, _and_ DeerPark Alpha 2, "gContextMenu.linkURL()" 
correctly returned the url of a given context link (eg: if on anchor or linked 
image) -- in firefox 1.5 BETA 1 it fails, throwing out of the javascript that 
called it.

temporary workaround is to call "gContextMenu.link.href" instead, but breaking 
the convenience function could cause a lot of unecessary headaches for extension 
developers.

Reproducible: Always

Steps to Reproduce:
1. call gContextMenu.linkURL() from an extension's javascript (eg: in a popup 
handler)
2. "boom"

Actual Results:  
throws

Expected Results:  
gContextMenu.linkURL() should have returned the correct link/href, equal to 
"gContextMenu.link.href"

Comment 1

[Dave Townsend [:mossop]]

*** Bug 307956 has been marked as a duplicate of this bug. ***

Comment 2

[Phil Ringnalda (:philor)]

It's not gone, just moved as part of bug 303181 - now there's a property
linkURL, and a function getLinkURL(). Close enough for -> WORKSFORME?

Comment 3

[Jesse Ruderman]

I broke gContextMenu.linkURL() with my changes in bug 303181.  The new correct
way is gContextMenu.linkURL.  Avoid using gContextMenu.link.href or
gContextMenu.getLinkURL(), since those can change while the context menu is
visible, leading to potential security holes if you check the href when the
context menu appears and use the href when a menu item is selected.

My changes:
http://bonsai.mozilla.org/cvsquery.cgi?who=jruderman%25hmc.edu&date=explicit&mindate=2005-08-11+23%3A55&maxdate=2005-08-11+23%3A55

Comment 4

[Mike Connor [:mconnor]]

Yes, these changes had an impact, but we made the decision that we needed to fix
the broken methods and replace them for 1.5, so its necessary pain for extension
devs.

Comment 5

[Alexander M Beedie]

ok, that's good. i did search for anything referencing this before reporting, 
but it seems i'm not authorised to view #303181 -- presumably wouldn't show up 
in the search either. presumably a security related issue?

anyway, cheers for the crisp clarification on the new properties/methods: bit of 
a nightmare exploring all the recent changes as the venkman debugger isn't up & 
running in 1.5 yet.

(also, thanks for the checkin link -- much clearer what was going on now)