308017 - Bidi: up/down-arrow sometimes behave incorrectly after switching keyboard layout

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

In the following testcase, in the top (RTL) textarea:
https://bugzilla.mozilla.org/attachment.cgi?id=193730

1. place the caret to the left of the "E"
2. press down-arrow
3. press up-arrow
4. switch to an RTL keyboard layout. The caret correctly moves to the right of
the "h".
5. Press down-arrow

Notice that the caret will move to the same place it moved after step 2, i.e.
below the "E", instead of below the "h".

The fix should be calling InvalidateDesiredX() in
nsTypedSelection::SelectionLanguageChange().

Comment 1

[Uri Bernstein]

Attachment: patch

Nothing much to say here.

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 195632 [details] [diff] [review]
patch

Yes.

Comment 3

[Asaf Romano (gone)]

Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v  <--  nsSelection.cpp
new revision: 3.205; previous revision: 3.204
done

Comment 4

[Uri Bernstein]

Checked in to 1.8.1 branch:
Checking in mozilla/layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v  <--  nsSelection.cpp
new revision: 3.199.2.4; previous revision: 3.199.2.3
done