Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 308045 - fraction line is shifted
: fraction line is shifted
: fixed1.8
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: ---
Assigned To: rbs
: Hixie (not reading bugmail)
: Anthony Jones (:kentuckyfriedtakahe, :k17e)
Depends on:
Blocks: 306543
  Show dependency treegraph
Reported: 2005-09-11 11:30 PDT by rbs
Modified: 2005-09-16 16:36 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (8.41 KB, patch)
2005-09-11 15:54 PDT, rbs
roc: review+
roc: superreview+
asa: approval1.8b5+
Details | Diff | Splinter Review

Comment 1 rbs 2005-09-11 15:54:32 PDT
Created attachment 195683 [details] [diff] [review]

Following the general sweep of bug 306543 to improve the inter-spacing, I got
feedback from wikipedia folks that it did the trick for them. I am now turning
attention to the edge cases. As far I can tell, this patch covers all the
remaining tags that need special treatments. It covers <mfrac>, <msqrt>,
<mfenced>, which contain things like the fraction line, the sqrt glyph and sqrt
bar, or fences and separators that are part of the flow without having frames.

[Note: I am aware of the very particular bug 118743. It is quite different and
is not my radar in this round.]
Comment 2 rbs 2005-09-11 18:34:55 PDT
I would also like in the course of checkin this patch, to update the spacing
table in nsMathMLContainerFrame.cpp as follows:
   /*           Ord  OpOrd OpInv OpUsr Inner Italic Upright */
-  /*Ord  */   {0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00},
+  /*Ord  */   {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00},
   /*OpOrd*/   {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
   /*OpInv*/   {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
   /*OpUsr*/   {0x01, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01},
-  /*Inner*/   {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00},
+  /*Inner*/   {0x01, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01}, <<HERE
-  /*Italic*/  {0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x01},
+  /*Italic*/  {0x00, 0x00, 0x00, 0x01, 0x01, 0x00, 0x01},
-  /*Upright*/ {0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x01}
+  /*Upright*/ {0x00, 0x00, 0x00, 0x01, 0x01, 0x01, 0x01}

<mfrac> is of type 'Inner' on that table. So the change updates its row (resp.
column) to also put a thin space before (resp. after) a fraction if it is
preceded (resp. followed) by an Ord, Italic, or Upright, MathML frame type.
Comment 3 rbs 2005-09-15 16:40:56 PDT
roc, I will be travelling next week and won't have a chance to follow-up. Would
you mind r/sr now so that I can request branch approval?
Comment 4 rbs 2005-09-15 16:52:39 PDT
Comment on attachment 195683 [details] [diff] [review]

Remaining piece to go with bug 308045.
Comment 5 rbs 2005-09-15 17:39:53 PDT
Checked in the trunk.
Comment 6 rbs 2005-09-16 16:36:42 PDT
Checked in the 1.8 branch.

Note You need to log in before you can comment on or make changes to this bug.