308094 - Increase the default size of the download window so that all buttons are visible

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, enhancement)

Description

[Nick Kreeger]

Currently, the default size of the download window doesn't show all the buttons
in the download window toolbar, increase the default/minimum size of the
download window to fix this.

Comment 1

[Jasper]

Nick I would disagree with this. What I think should be done is the following.

The default set should be:
Pause/Resume - Cancel/Retry - space - Open - Show - space - Clean Up

This set fit's nicely on the current bar and shows all the essential options to
the user. If the user sets the toolbar not to use text they can even put another
2 items without having to scroll. Note that I think it's more then ok to leave
some of the items in the customization sheet.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 310942 has been marked as a duplicate of this bug. ***

Comment 3

[Nick Kreeger]

Whats the status of this bug, Mike do we still want to do this, or change the
default toolbar set?

Comment 4

[Yuan Qi]

The layout proposed makes it very easy to cancel a download when the user really
wants to Pause it instead. My suggestion is to move these dangerous operations
to the contextual menu.

Also, the cancel function is pointless. The user will either follow it with
restart or delete. So why not just make restart and delete available and remove
the cancel function?

Lastly, the user should be allowed to delete a downloading/downloaded item by
dragging the item to the trash can.

Comment 5

[Samuel Sidler (old account; do not CC)]

(In reply to comment #4)
> Also, the cancel function is pointless. The user will either follow it with
> restart or delete. So why not just make restart and delete available and remove
> the cancel function?

How do you cancel a download with no "Cancel" button? Say we use "Delete", what
happens when a user accidentally deletes a download he/she really wanted? How
does the user bring it back? And if he/she has navigated away from the page they
were on, they can no longer find the link to the download he/she wanted.

As it stands now (or will stand at least), a users can cancel a download and
restart it at any point. If they delete it, there's really no way to restart it.

Comment 6

[Samuel Sidler (old account; do not CC)]

It'd be good to have the standard set/size ironed out for 1.0.

Mike, can you give some input on this bug?

Comment 7

[Mike Pinkerton (not reading bugmail)]

should be easy.

Comment 8

[Nick Kreeger]

Attachment: Changes the default name of the ProgressView to ProgressView1 so update will be seen without user trashing pref plist

Comment 9

[Nick Kreeger]

Attachment: New ProgressView.nib, now the default width is 300 px, so all the default buttons fit on the default width

This is the updated NIB, sets the default panel size to 300 as well as content inside the panel

Comment 10

[Samuel Sidler (old account; do not CC)]

(In reply to comment #8)
> Created an attachment (id=201570) [edit]
> Changes the default name of the ProgressView to ProgressView1 so update will be
> seen without user trashing pref plist

Do we really care about that? I'd think we'd only care about new users as those downloading nightlies probably know about new features. Users switching from 0.8 to 1.0 will already notice the difference because the name of the plist changed.

Either way, just thought I'd add a comment.

Comment 11

[Nick Kreeger]

We did the same thing when we changed the toolbar, i don't think every user has resized their download window.

Comment 12

[Nick Kreeger]

Notice that if we want to keep the pref (and only worry about new installs of the app) then don't use the patch. All the patch is for is to ensure that Camino uses a diffrent setting for the Download window so the default size will be what's in the new NIB file.

Comment 13

[Mark Mentovai]

Comment on attachment 201571 [details]
New ProgressView.nib, now the default width is 300 px, so all the default buttons fit on the default width

Don't you want ProgressDialog.nib?

Comment 14

[Nick Kreeger]

Attachment: Oops, this is ProgressDialog.nib

Comment 15

[Mark Mentovai]

Comment on attachment 201570 [details] [diff] [review]
Changes the default name of the ProgressView to ProgressView1 so update will be seen without user trashing pref plist

Not gonna do this, but we can change your e-mail address if you want.

Comment 16

[Nick Kreeger]

Attachment: correct size for CHStackView

After further testing of the modified NIB, the old attatchment had a problem with the size in CHStackView. This is now correct

Comment 17

[Mark Mentovai]

Comment on attachment 201650 [details]
correct size for CHStackView

In the previous nib, the CHStackView was the width of the download manager window (300px), which put it beneath the window's scrollbar.

Comment 18

[Mike Pinkerton (not reading bugmail)]

landed trunk and branch