308099 - Cleanup of the xmlHttpRequest code in nsExtensionManager.js.in

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

This is a followup bug to address the review comments in bug 307235 that were
made after checkin for 1.8b4

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

This addresses everything from bug 307235 except I kept the QI in the error
handler since I recall not always having a channel in all cases (e.g. local
file). I can check that later if you like and I noticed nsUpdateService.js.in
handles this the same way.

Comment 2

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.151; previous revision: 1.150
done

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 195726 [details] [diff] [review]
patch

>Index: toolkit/mozapps/extensions/src/nsExtensionManager.js.in

>   onXMLError: function(aEvent, aItem) {
>+    var request = event.target;

s/event/aEvent/, right?

Comment 4

[Robert Strong (they/them - no direct email)]

Thanks Gavin!

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.144.2.7; previous revision: 1.144.2.6
done