Closed
Bug 30846
Opened 25 years ago
Closed 25 years ago
doctype declaration tag gets corrupted on input
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
M14
People
(Reporter: Jos.vandenOever, Assigned: harishd)
References
()
Details
(Keywords: regression, Whiteboard: [PDT+] w/b minus on 03/10 - fix in hand.)
Attachments
(4 files)
|
1.01 KB,
patch
|
Details | Diff | Splinter Review | |
|
985 bytes,
text/html
|
Details | |
|
985 bytes,
patch
|
Details | Diff | Splinter Review | |
|
623 bytes,
patch
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; N; NT4.0; en-US) Mozilla/m13
BuildID: 2000022820
The first tag in a HTML page, the DOCTYPE tag, is changed by Mozilla editor to a
nonsensical version by changing `>' into `>(newline)>'
Reproducible: Always
Steps to Reproduce:
1. open mentioned file
2. `edit page'
3. `save as ...'
4. look at code difference
Actual Results: The first tag in the mentioned file was originally
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
after opening and saving in the editor it was
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
>
including the newline and the > The > is the main problem. It shouldn't be
there.
Expected Results: The tag shouln't have been changed at all.
Or even better, Mozilla should use it to determine the features allowed in the
editor, but is probably asking too much.
|
||
Comment 1•25 years ago
|
||
reassign to akkana for initial investigation
nominate for beta1 since this is corruption of data (standards data no less!) and
a regression
Sujay--can you narrow down when this broke?
Assignee: brade → akkana
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: beta1,
regression
OS: Windows NT → All
Hardware: PC → All
Summary: doctype declaration tag gets mangled on input → doctype declaration tag gets corrupted on input
Target Milestone: M14
I think I know what the problem ( > )is and should be able to fix it of the
parser end. As for the extra newline..I have no idea..
|
||
Comment 4•25 years ago
|
||
Thanks, Harish! Let me know when you have the > patch, and if you need help
testing; and if you're still seeing the extra newline at that point, pass it
back to me and I'll track that part down.
Assignee: akkana → harishd
|
|
||
Comment 6•25 years ago
|
||
The patch builds fine on linux and does solve the problem.
The newline is still there -- I'll look at that -- but we should definitely take
Harish's fix for the beta.
Putting on PDT+ radar for beta1. Will be minus if not fixed by 03/10.
Whiteboard: [PDT+] w/b minus on 03/10 - fix in hand.
|
|
||
Comment 10•25 years ago
|
||
The revised patch (03/10/00 10:41) looks fine on linux, and does fix both
newline and > problems.
|
||
Comment 11•25 years ago
|
||
Harish,
What held up the landing? I see a reviewed fix in hand... but no landing.
Has it been tested? Is there a landing plan? I'll hold off transitioning to
PDT- to get some feedback here. The beta date is commin', and it won't wait.
Thanks,
Jim (past 3/10...) Roskind
|
|
Assignee | |
Comment 12•25 years ago
|
||
Fix is in ( Both on the TIP and the BRANCH ).
Marking FIXED.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•25 years ago
|
||
OKAY, now I see a little box at the end of the doctype declaration tag.
Harish said to REOPEN this one....let me know if you want me to file a new
bug instead...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 14•25 years ago
|
||
okay, found it. The problem is caused in CDoctypeDeclToken::Consume(). Where,
while consuming the doctype string, we are also including '\r','\n' etc., that
preceed the DOCTYPE tag. This is the reason behind the wierdness..
FYI: This problem actually got masked by the actual 30846 bug. but now....it's
exposed :)
Adding rickg....because per. cvs log, he touched this method ( in question )
last. Waiting for rickg's comments.
Status: REOPENED → ASSIGNED
|
|
Assignee | |
Comment 15•25 years ago
|
||
|
|
Reporter | |
Comment 16•25 years ago
|
||
for me it's fixed in build 2000031317
|
|
||
Comment 17•25 years ago
|
||
resolving this as fixed based on comments by Jos.vandenOever@fenk.wau.nl
Sujay will verify
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
|
|
||
Comment 18•25 years ago
|
||
btw, Sujay if you still see the problem, could you clarify if the problem is on
just one platform or every platform?
|
|
||
Comment 19•25 years ago
|
||
verified in 3/14 build. filing new bug for the box issue...
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•