Closed
Bug 308520
Opened 19 years ago
Closed 19 years ago
Replace column ids by column objects in methods related to horizontal scrolling.
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: janv, Assigned: janv)
References
Details
Attachments
(1 file)
|
6.04 KB,
patch
|
bzbarsky
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #196053 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #196053 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
OS: MacOS X → All
|
||
Comment 2•19 years ago
|
||
Comment on attachment 196053 [details] [diff] [review] patch I don't think I'm allowed to r+sr in this module.
Attachment #196053 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #196053 -
Flags: superreview+
Attachment #196053 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #196053 -
Flags: review?(bzbarsky)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 196053 [details] [diff] [review] patch I guess we already have these casts around, but those are a good way to crash, in general, since absolutely nothing guarantees that the object passed in will in fact be an nsTreeColumn. Please file a followup bug to eliminate the casts in favor of actually checkin the object type (eg QI to a private non-scriptable interface, or "QI" to the concrete class the way nsStandardURL does, or something).
Attachment #196053 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked in the patch and filed bug 309429.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•