308521 - Hover area for links appears to be too far to the left

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Dave Townsend [:mossop]]

Visit the url and try to hover over the links in the menu on the right. You
should find that the area that highlights the link is too far to the left and
wierd things start happening when that area extends over the previous link, see
the Specs links especially.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050914
Firefox/1.6a1 ID:2005091406

Comment 1

[Dave Townsend [:mossop]]

It has been suggested that this is a regression from bug 296036.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The regression was between 2005-08-06-05-trunk and 2005-09-03-06-trunk.  Working
on isolating further, but I suspect some of the view coordinate changes.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It was between 2005-08-22-05-trunk and 2005-08-23-05-trunk.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 296036 seems most likely, since when moving through in some directions I see
oscillation that suggests mMouseLocation in the view manager is being set
incorrectly.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Note that I've actually seen the oscillation on bonsai query results a bit
lately, but never been able to find a reliable testcase.)

Comment 6

[Bruno 'Aqualon' Escherl]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050910
SeaMonkey/1.0a

Comment 7

[Erik Fabert]

Attachment: testcase

Try to enter the link from the right side, moving the pointer left. When the
link finally highlights, move the pointer left and right to see the oscillating
effect. Seems the negative left margin is the culprit.

Comment 8

[Eli Friedman]

Attachment: Patch

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 196464 [details] [diff] [review]
Patch

good catch

Comment 10

[Jonathan Stanley]

Duplicate of bug 306179 (see comment #7)?

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk (since I don't think the patch author has cvs access).

Comment 12

[Jonathan Stanley]

(In reply to comment #11)
> Checked in to trunk (since I don't think the patch author has cvs access).

Fix works as expected with sites reported in bug 308521 and bug 306197 and all
test-cases in said bugs.

Texted with build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050918
Firefox/1.6a1 ID:2005091820

Comment 13

[Jonathan Stanley]

(In reply to comment #12)
> (In reply to comment #11)
> > Checked in to trunk (since I don't think the patch author has cvs access).
> 
> Fix works as expected with sites reported in bug 308521 and bug 306197 and all
> test-cases in said bugs.
> 
> Texted with build:
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050918
> Firefox/1.6a1 ID:2005091820

Sorry for bugspam, I meant bug 306179...

Comment 14

[Martijn Wargers (dead)]

*** Bug 306179 has been marked as a duplicate of this bug. ***