308536 - Support monochrome cursors when GTK version is less than 2.4

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Darin Fisher]

Support monochrome cursors when GTK version is less than 2.4

It'd be cool if we still supported URL-valued CSS cursors on older systems that
do not have the ability to render full-color cursors.  Biesi suggested that we
could do this by rendering the supplied images as monochrome.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

I'm not sure whether this is the best possible algorithm... I'm currently
making the pixel black if the average of the r,g,b values is < 128.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

darin: could you verify that this patch works under your gtk version? I only
have gtk 2.6 available.

Comment 3

[Darin Fisher]

Works great!  Thanks for the patch, biesi :)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Would it make more sense to look at the luminance instead of the average?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, it may... do we have an easy way to get that?

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://lxr.mozilla.org/seamonkey/source/layout/base/nsCSSColorUtils.h#64 and the corresponding cpp has some code.  Maybe it should move to nsColor?

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 196101 [details] [diff] [review]
patch

ok, I think I don't want to move that function around as part of this bug, so I'll file a new bug on that.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

filed bug 329646 for luminance

Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.160; previous revision: 1.159
done

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 196101 [details] [diff] [review]
patch

I think this would also be good for firefox 2.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm not really sure about that ... I'd like to see some reports of actual problems in the wild

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Checked in on MOZILLA_1_8_BRANCH

Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.145.2.3; previous revision: 1.145.2.2
done