Closed Bug 308573 Opened 19 years ago Closed 19 years ago

use if (NS_FAILED(...)) instead of if NS_FAILED(...)

Categories

(Core :: Networking: Cookies, defect)

Product:
Core
Component:
Networking: Cookies
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: timeless, Assigned: darin.moz)

References

(
URL
)

Details

Attachments

(3 files)

one-liner patch
705 bytes, patch
darin.moz
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review
fix other instances
8.77 KB, patch
darin.moz
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review
And NS_SUCCEEDED
4.57 KB, patch
darin.moz
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
just because it happens to compile doesn't mean we should do it (it 
scares/confuses people). shaver, biesi and myself agree.
looks like this entered rev 1.82 when nsCookieService.cpp lived in
extensions/cookie.  patches welcome.
Target Milestone: --- → Future
Attached patch one-liner patch — — Splinter Review 
does anything else need to be done to patch this, other than changing this one
line?
Attachment #196112 - Flags: review?(darin)
Comment on attachment 196112 [details] [diff] [review]
one-liner patch

r+sr=darin
Attachment #196112 - Flags: superreview+
Attachment #196112 - Flags: review?(darin)
Attachment #196112 - Flags: review+
This patch fixes other instances of this bug throughout the codebase.
Attachment #196212 - Flags: superreview?(darin)
Attachment #196212 - Flags: review?(darin)
Attachment #196212 - Flags: superreview?(darin)
Attachment #196212 - Flags: superreview+
Attachment #196212 - Flags: review?(darin)
Attachment #196212 - Flags: review+
Attached patch And NS_SUCCEEDED — — Splinter Review 

  

  



        Attachment #196215 -
        Flags: superreview?(darin)

        Attachment #196215 -
        Flags: review?(darin)

    
  

        Attachment #196215 -
        Flags: superreview?(darin)

        Attachment #196215 -
        Flags: superreview+

        Attachment #196215 -
        Flags: review?(darin)

        Attachment #196215 -
        Flags: review+

    
    

    
  
Timeless checked in all three attachments. Marking fixed (but if you find more
instances of this, please reopen).

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: