308627 - Camino should not set the default FTP client.

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Wevah (Nate Weaver)]

Whenever a browser is selected from the "Default Web Browser" popup, it sets the
browser as the default FTP client as well. It shouldn't do this. (I don't know
that we should be setting the default Gopher client, either, but who uses Gopher
nowadays? ;) )

The line that does this is:

_LSSetDefaultSchemeHandlerURL(@"ftp", browserURL);

In NSWorkspace+Utils.mm. (Currently line 100:
http://lxr.mozilla.org/mozilla/source/camino/src/extensions/NSWorkspace+Utils.m#100
.)

Comment 1

[Mike Pinkerton (not reading bugmail)]

worth discussion, i'll put on the 10 radar.

Comment 2

[Simon Fraser [no longer active]]

I concur

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Also, Camino doesn't repect the FTP pref, either, if it's set.  I have NetFinder
set as my FTP client and Camino blithely ignores it and handles FTP itself. 
This is not always a bad thing (say, for ADC downloads where the URL keeps
requiring a password), but I don't think Camino should be doing it.  I can open
another bug on this if needed.

Comment 4

[Mark Mentovai]

Simon, I join your concurring opinion.  I don't care either way about gopher.

Regarding comment 3, I'd rather not pass things to the ftp handler unless
Safari-like behavior was implemented: if an ftp URL doesn't end in a slash,
attempt an FTP download, retrieve if a file, and pass to the ftp handler if a
directory.  Usernames and passwords, when needed, can be passed in the URL. 
That's another bug.

or maybe:

If the Finder is the ftp handler, handle ftp internally, otherwise, pass it to
the ftp handler.  (It's still another bug.)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bug 308758 filed on comment 3.

Comment 6

[Mark Mentovai]

I checked in Wevah's suggestion to remove the offending line from NSWorkspace+Utils.mm (comment 0), r=me.  Trunk and branch.