308680 - "Reset Camino" appears to hang when many items are in the dowload manager

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[ernstwagner]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050914 Camino/1.0a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050914 Camino/1.0a1

camino does nor reset (menu: 'reset camino') it frozes so that only a forced
quit helps. I get the same effect when I try to clean the download window.

Reproducible: Always

Comment 1

[Wevah (Nate Weaver)]

How many items are in your download window? If you have a lot of items in there,
it takes a long time to empty.

Comment 2

[ernstwagner]

(In reply to comment #1)
> How many items are in your download window? If you have a lot of items in there,
> it takes a long time to empty.

there were many. 100? when I deleted them 10 by 10 I reached suddenly the point where I could clean 
them all. and after that, the reset menu worked properly again. too many items in the download window 
block the reset menu!

Comment 3

[Nick Kreeger]

Taking

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Kicking off UNCO, since we kinda knew there might be issues when many downloads
were kept in the manager.

We need to fix this for 1.0, right?

Comment 5

[Nick Kreeger]

Correct, I will look at cleaning up the reset code and download list saving. We
are getting a little backed up on download patches, trying to keep them from
being bit-rotted.

Comment 6

[Mike Pinkerton (not reading bugmail)]

we need to get this fixed for 1.0

Comment 7

[Nick Kreeger]

Attachment: Proposed patch

The problem wasn't with saving the download list, it was the redraw that was happening every time a download was removed from the list. I added a in-param to |removeDownload| in ProgressDlgController. This is needed because there are some cases when we do want the stack to reload itself and redraw. 

That being said this patch fixes the reset camino and clean-up downloads hanging!

Feel free to test with the attached downloads.plist that I attachted, it saves time from downloading a bunch!

Comment 8

[Nick Kreeger]

Attachment: downloads.plist sample

Just to help for testing, replace your downloads.plist in your /app support/camino/ folder and run, saves time from building up the list manually

Comment 9

[Nick Kreeger]

Attachment: Updated Patch

As pink pointed out in IRC, this does not fix the case of the user manually selecting all of them and clicking remove. So pull out the call to [self rebuildViews] in |removeDownload:| in ProgressDlgController. 

Instead, call [self rebuildViews] after a looped iteration when calling |removeDownload:| for ProgressDlgController.

Comment 10

[Mike Pinkerton (not reading bugmail)]

fixed trunk and branch