308819 - Clicking either on the live bookmark button/menu or on the padlock button focuses the location bar if clickSelectsAll is enabled (default on windows)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Asaf Romano (gone)]

seen on: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050915 Firefox/1.4

After closing the "Add Live Bookmark" dialog, the location bar is focused
instead of the content area.

STR:
1. Focus the content area
2. click the add live bookmark icon (in the location bar).
3. close the dialog

-> The location bar is focused.

Comment 1

[Asaf Romano (gone)]

Also:
 1. If the live bookmark button is a menu of feeds, clicking on it does
clickSelectAll in the location bar
 2. same thing happens with the padlock button

Comment 2

[Asaf Romano (gone)]

Attachment: patch

OK, i tried to do something a bit smarter, but gecko's focus reminded me why
not.

Comment 3

[Asaf Romano (gone)]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.503; previous revision: 1.502
done

Comment 4

[Mike Schroepfer]

Comment on attachment 196350 [details] [diff] [review]
patch

Approved for 1.8b5 per bug meeting

Comment 5

[Asaf Romano (gone)]

1.8 Branch:
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.29; previous revision: 1.479.2.28
done