30886 - Asserts in webshell/docshell

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect, P3)

Description

[Akkana Peck]

Run the editor on an existing page, e.g. mozilla -edit file:/tmp/foo.html (or
whatever).

Make a minor change.

Do File->Preview, and answer no to "Do you want to save?"

A browser preview window pops up.

While the browser window is still up, go back to the editor window, and another
change, do File->Preview, and answer no again.

The existing browser window blanks, you get a JS error on the console:

JavaScript Error: TypeError: window.content.document has no properties
URL: chrome://global/content/charsetOverlay.js
Line number: 93


and you get two asserts every time you move focus into it:

###!!! ASSERTION: NS_ENSURE_TRUE(mContentViewer) failed: 'mContentViewer', file
nsDocShell.cpp, line 332
###!!! Break: at file nsDocShell.cpp, line 332
###!!! ASSERTION:
NS_ENSURE_TRUE(NS_SUCCEEDED(GetPresContext(getter_AddRefs(presContext))))
failed: '(!((GetPresContext(getter_AddRefs(presContext))) & 0x80000000))', file
nsDocShell.cpp, line 349
###!!! Break: at file nsDocShell.cpp, line 349

and three asserts every time you blur it:

###!!! ASSERTION: NS_ENSURE_TRUE(mContentViewer) failed: 'mContentViewer', file
nsDocShell.cpp, line 332
###!!! Break: at file nsDocShell.cpp, line 332
###!!! ASSERTION:
NS_ENSURE_TRUE(NS_SUCCEEDED(GetPresContext(getter_AddRefs(presContext))))
failed: '(!((GetPresContext(getter_AddRefs(presContext))) & 0x80000000))', file
nsDocShell.cpp, line 349
###!!! Break: at file nsDocShell.cpp, line 349
###!!! ASSERTION: NS_ENSURE_TRUE(presShell) failed: 'presShell', file
nsGlobalWindow.cpp, line 2241
###!!! Break: at file nsGlobalWindow.cpp, line 2241

Anyone have any ideas what's going on?  The editor code being executed here is
doing:

    window.openDialog("chrome://navigator/content/navigator.xul",
                      "EditorPreview",
                      "chrome,all,dialog=no",
                      fileurl );

-- is there something there we shouldn't be doing?

Comment 1

[Akkana Peck]

I'm going to give this to cata because the charsetOverlay.js problem is the
first one that shows up.

Comment 2

[Simon Fraser [no longer active]]

Note that bug 29807 also describes that same JS error, which shows up on Mac 
every time you run.

Comment 3

[Frank Tang]

cata- can you reproduce this ?

Comment 4

[travis]

This sounds like a reloading of open chrome problem....  Danm has a bug already 
about fixing this.  I'm flipping this over to him and marking it as a 
dependency of his other bug.

Comment 5

[Peter Trudelle]

Mass moving M17 bugs to M18

Comment 6

[Peter Trudelle]

mass-moving all bugs to m21 that are not dofood+, or nsbeta2+

Comment 7

[Akkana Peck]

Just tried the scenario described in the bug; now, instead of asserting, the app
crashes.  Adding crash keyword.

Comment 8

[Brant Gurganus]

By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and
<http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss
bugs are of critical or possibly higher severity.  Only changing open bugs to
minimize unnecessary spam.  Keywords to trigger this would be crash, topcrash,
topcrash+, zt4newcrash, dataloss.

Comment 9

[Andreas Kunz]

This is now "File - Browse page" and it works for me on Win2k.
Does anybody still see it?

Comment 10

[Andreas Kunz]

I also tested 1.6 on Linux now and I'll take the liberty to resolve this. Last
reported crash was three years ago, anyway...