packager.mk fails when MOZ_PKG_REMOVALS is unset

VERIFIED FIXED in mozilla1.8beta5

Status

()

Core
Build Config
--
critical
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: krmathis@gmail.com, Assigned: Mark Mentovai)

Tracking

({fixed1.8})

Trunk
mozilla1.8beta5
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050916 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050916 Camino/1.0+

The Disk Image packager for Camino errors out before it creates the actual Disk
Image.

This code failed:
checkout finish: Fri Sep 16 17:50:28 CEST 2005

While this one completed successfully:
checkout finish: Thu Sep 15 19:57:54 CEST 2005

--------------------------------------
** BUILD SUCCEEDED **
rsync -a --copy-unsafe-links build/Deployment/Camino.app/ ../dist/Camino.app
/usr/bin/make export
make[1]: Nothing to be done for `export'.
/usr/bin/make libs
Creating package directory...
building file list ... done
Camino.app/
Camino.app/Contents/
--snip--
Camino.app/Contents/Resources/zoomOut.tiff

sent 22591792 bytes  received 9020 bytes  9040324.80 bytes/sec
total size is 22556949  speedup is 1.00
Stripping package directory...
signing nss libraries
Generating DSA Key Pair....../../dist/camino/libsoftokn3.dylib: File not found.
done
Removing unpackaged files...
cd ../../dist/camino/Camino.app/Contents/MacOS; rm -rf 
/Users/krmathis/Camino/mozilla/camino_7450_optimized/config/nsinstall -t 
../../dist/camino/Camino.app/Contents/MacOS
usage: /Users/krmathis/Camino/mozilla/camino_7450_optimized/config/nsinstall [-C
cwd] [-L linkprefix] [-m mode] [-o owner] [-g group]
                                                                            
[-DdltR] file [file ...] directory
make[1]: *** [mozilla-1.9a1.en-US.mac.dmg] Error 2
make: *** [all] Error 2
--------------------------------------


Reproducible: Always

Steps to Reproduce:
1. Build Camino
2. Run 'make' in "camino/installer" or "MOZ_OBJDIR/camino/installer"

Actual Results:  
Packager errors out (dont create the Camino.dmg)

Expected Results:  
Packager successfully creates the Camino.dmg


Some more information:
* Building on Mac OS 10.4.2, using GCC 4.0.0 (build 5026).
* Building in an MOZ_OBJDIR.
(Reporter)

Updated

12 years ago
Version: unspecified → Trunk
(Assignee)

Updated

12 years ago
Blocks: 300136
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

12 years ago
Created attachment 196376 [details] [diff] [review]
MOZ_PKG_REMOVALS fix

Benjamin, when you fix bug 300136 on the branch, please include this change.
Assignee: pinkerton → mark
Attachment #196376 - Flags: review?(benjamin)
(Assignee)

Comment 2

12 years ago
No Camino trunk builds will be released until this is fixed.
Is this also the cause of the absent branch nightly for today?
(Assignee)

Comment 4

12 years ago
No, there was no branch nightly because someone conked boxset on the head while
it was building.
(Assignee)

Updated

12 years ago
Severity: normal → critical
Component: General → Build Config
Flags: review?(benjamin)
OS: MacOS X → All
Product: Camino → Core
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8beta5
(Assignee)

Updated

12 years ago
Summary: Disk Image packager errors out → packager.mk fails when MOZ_PKG_REMOVALS is unset
(Assignee)

Updated

12 years ago
Attachment #196376 - Flags: review?(benjamin)
(Assignee)

Comment 5

12 years ago
Comment on attachment 196376 [details] [diff] [review]
MOZ_PKG_REMOVALS fix

Retargeting review request, bsmedberg is on vacation.
Attachment #196376 - Flags: review?(benjamin) → review?(mscott)

Comment 6

12 years ago
Comment on attachment 196376 [details] [diff] [review]
MOZ_PKG_REMOVALS fix

r=darin
Attachment #196376 - Flags: review?(mscott) → review+
(Assignee)

Comment 7

12 years ago
Fixed!  (Thanks for the review, Darin.)
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

12 years ago
*** Bug 308783 has been marked as a duplicate of this bug. ***
(Reporter)

Updated

12 years ago
Status: RESOLVED → VERIFIED

Comment 9

12 years ago
Mark, we are going to need this on the branch as well if we fix 300136 for
Thunderbird too right?
(Assignee)

Comment 10

12 years ago
Fo' shizzle.

Comment 11

12 years ago
Comment on attachment 196376 [details] [diff] [review]
MOZ_PKG_REMOVALS fix

Per Mark. This patch needs to go into the branch before I can land the
Thunderbird fix for Bug #300136 which has already gone in for Firefox.
Attachment #196376 - Flags: approval1.8b5?

Comment 12

12 years ago
Comment on attachment 196376 [details] [diff] [review]
MOZ_PKG_REMOVALS fix

approving for the branch.
Attachment #196376 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 13

12 years ago
mscott, this patch can't be applied until the patch in bug 300136 is applied,
but that patch is broken unless this one is also present.  Conundrum?  Nah! 
Before checking bug 300136 in on the branch, make sure that this patch is also
applied to your tree.
Fixed on 1.8 branch at the same time as bug 300136 was landed on branch.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.