Closed Bug 308899 Opened 19 years ago Closed 19 years ago

AIX build break in xpconnect (xpcwrappednativeinfo.cpp)

Categories

(Core :: XPConnect, defect, P1)

Product:
Core
Component:
XPConnect
Platform:
Other
AIX
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8beta5

People

(Reporter: pkwarren, Assigned: bzbarsky)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Patch I just checked in; let's hope that fixes it.
926 bytes, patch
dbradley
: review+
brendan
: superreview+
brendan
: approval1.8b5+
Details | Diff | Splinter Review 
I was able to successfully build Mozilla earlier this morning on AIX, but a
later checkin appears to have caused the following build break:

"/home/tbox/sb/tinderbox/AIX_5.1_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednativeinfo.cpp",
line 695.19: 1540-0201 (S) The "delete" operator is not allowed for type
"AutoMarkingNativeInterfacePtrArrayPtr".
gmake[4]: *** [xpcwrappednativeinfo.o] Error 1

  

  



    
    

    
  
So it looks like the AIX tinderbox is not really happy... pkw, does that patch
fix things for you?  If so, we should get it in on branch.

  

  



    
    

    
  
(In reply to comment #2)
> So it looks like the AIX tinderbox is not really happy... pkw, does that patch
> fix things for you?  If so, we should get it in on branch.

Sorry I had stopped the tinderbox until I got a chance to look at this further.
I am restarting it now.

  

  



    
    

    
  
Boris - thanks for the quick fix! The AIX tinderbox is now up and running again.

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
Taking bug...

  

  


Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
  
Assignee: dbradley → bzbarsky
Status: REOPENED → NEW
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta5

    
    

    
  
Comment on attachment 196390 [details] [diff] [review]
Patch I just checked in; let's hope that fixes it.

We need post-facto reviews for this bustage fix, I think, and we should get it
in on the branch...

  

  



        Attachment #196390 -
        Flags: superreview?(brendan)

        Attachment #196390 -
        Flags: review?(dbradley)

        Attachment #196390 -
        Flags: approval1.8b5?

    
  
Status: NEW → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 196390 [details] [diff] [review]
Patch I just checked in; let's hope that fixes it.

Someone remind me what the C++ ISO spec says, if it does prescribe
unambiguously and completely?

/be

  

  



        Attachment #196390 -
        Flags: superreview?(brendan)

        Attachment #196390 -
        Flags: superreview+

        Attachment #196390 -
        Flags: approval1.8b5?

        Attachment #196390 -
        Flags: approval1.8b5+

    
    

    
  
Fixed on branch

  

  


Keywords: fixed1.8

    
    

    
  
Comment on attachment 196390 [details] [diff] [review]
Patch I just checked in; let's hope that fixes it.

r=dbradley

Well even if AIX isn't quite correct, is it really going to matter?

  

  



        Attachment #196390 -
        Flags: review?(dbradley) → review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: