308966 - Warn checkbox not enabling/disabling in update options

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dave Townsend [:mossop]]

When the options window is not in instant apply, the warn checkbox doesnt enable
and disable with the radio button setting until the options window is closed and
opened again.

I have a fix in progress.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Patch

A change event is necessary so the onchange handler on the preference is
called. The call to updateElements is then unnecessary since that will happen
in the change handler in the preference binding.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Second patch

On second thoughts. It's only sensible to fire the change event when there is
an actual change, not the situation when we set the preference's value at the
start. There we should only update the elements.

Comment 3

[Dave Townsend [:mossop]]

Fixed on trunk

Comment 4

[Asaf Romano (gone)]

Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.31.2.4; previous revision: 1.31.2.3
done