309011 - Options - Tabs , items are in incorrect order

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050916
Firefox/1.4 ID:2005091619

Open Options window and select "tabs", lower section

[] Force links that open new windows to open in
  0 The same window as the link
  0 A new tab
[] Hide the tabbar when only one website is open
[] Select new tabs opened from links
[] Warn me when closing multiple tabs

- item #1 and #3 are open links behaviour
- item #2 and #4 are about tab behaviour


should be:

[] Force links that open new windows to open in
  0 The same window as the link
  0 A new tab
[] Select new tabs opened from links
[] Hide the tabbar when only one website is open
[] Warn me when closing multiple tabs

- item #1 and #2 are open links behaviour
- item #3 and #4 are about tab behaviour

In contrast to the current layout where they are mixed

Comment 1

[Peter van der Woude [:Peter6]]

simple fix in tabs.xul

change order from:
<checkbox id="hideTabBar" label="&hideTabBar.label;"
          accesskey="&hideTabBar.accesskey;"
          preference="browser.tabs.autoHide"/>
<checkbox id="loadInBackground" label="&loadInBackground.label;"
          accesskey="&loadInBackground.accesskey;"
          preference="browser.tabs.loadInBackground"/>

to:
<checkbox id="loadInBackground" label="&loadInBackground.label;"
          accesskey="&loadInBackground.accesskey;"
          preference="browser.tabs.loadInBackground"/>
<checkbox id="hideTabBar" label="&hideTabBar.label;"
          accesskey="&hideTabBar.accesskey;"
          preference="browser.tabs.autoHide"/>

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: patch

Attached a patch of the proposed changes.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: patch

You know it's late when you attach a patch in the wrong format :p
Corrected mistake and attached new revision.

Comment 4

[u60234]

Don't forget that the help file prefs.xhtml should also be updated.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Peter, before requesting approval here, take a peek at bug 308396, which will
hopefully (at part, at least) make it into 1.5 and switch the prefs to:

Links that open new windows should be opened in:
(*) new windows
( ) new tabs in the most recent window

[ ] Always select new tabs
[x] Hide the tab bar when only one web site is open
[x] Warn when closing multiple tabs

Comment 6

[Peter van der Woude [:Peter6]]

Mike, I'll just leave it as is and see if Ben get's that stuff in before beta2
(planned october 5).

Comment 7

[Mike Connor [:mconnor]]

Please renominate if the other bug stalls.

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: prefs.xhtml update

(In reply to comment #4)
> Don't forget that the help file prefs.xhtml should also be updated.

Updated help file. Just in case the UE changes in bug 308396 don't make it.

Comment 9

[Ryan Flint [:rflint] (ping via IRC for reviews)]

It seems a bit pointless to swap these around now that people are used to the order. If there are any objections, feel free to reopen :)