309046 - XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Anand Aiyer]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set 
somewhere in runtime before a call to XMLRPc

Reproducible: Always

Steps to Reproduce:

Comment 1

[Anand Aiyer]

Attachment: Fixes the problem

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 196537 [details] [diff] [review]
Fixes the problem

r=me

What about the code near line 546:
                var keys = obj.getKeys({});
                for (var k in keys) {

is this also an array?

Comment 3

[Anand Aiyer]

Yes, keys is also an array, this also needs to be changed.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 196537 [details] [diff] [review]
Fixes the problem

sr=jst with the additional change mentioned above.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Anand, let me know when you have an updated patch ready for checkin, ok?

Comment 6

[Anand Aiyer]

Attachment: updated patch

here is the updated patch

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in to the trunk.  Anand, thanks for the patch!