XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set

RESOLVED FIXED

Status

()

Core
XML
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Anand Aiyer, Assigned: Anand Aiyer)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

XMLRPC doesnt work if Array.prototype.[...] or String.prototype.[...] are set 
somewhere in runtime before a call to XMLRPc

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

12 years ago
Created attachment 196537 [details] [diff] [review]
Fixes the problem
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 196537 [details] [diff] [review]
Fixes the problem

r=me

What about the code near line 546:
                var keys = obj.getKeys({});
                for (var k in keys) {

is this also an array?
Attachment #196537 - Flags: superreview?(jst)
Attachment #196537 - Flags: review+
(Assignee)

Comment 3

12 years ago
Yes, keys is also an array, this also needs to be changed.
Comment on attachment 196537 [details] [diff] [review]
Fixes the problem

sr=jst with the additional change mentioned above.
Attachment #196537 - Flags: superreview?(jst) → superreview+
Anand, let me know when you have an updated patch ready for checkin, ok?
(Assignee)

Comment 6

12 years ago
Created attachment 208264 [details] [diff] [review]
updated patch

here is the updated patch
Assignee: xml → aaiyer
Checked in to the trunk.  Anand, thanks for the patch!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.