309050 - Javascript error in pageInfo.js when the page contains: <iframe style="display: none;">

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Florian Quèze [:florian]]

With a page containing "<iframe style="display: none;">" I get those errors in
the javascript console when I open the Page Info window:

Firefox 1.0.4 :
Error: elem.ownerDocument.defaultView has no properties
Source File: chrome://browser/content/pageInfo.js
Line: 477

SeaMonkey (20050904):
Error: elem.ownerDocument.defaultView.getComputedStyle(elem, "") has no properties
Source File: chrome://navigator/content/pageInfo.js
Line: 524

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050918 Firefox/1.6a1 :
Error: elem.ownerDocument.defaultView.getComputedStyle(elem, "") has no properties
Source File: chrome://browser/content/pageInfo.js
Line: 487

Comment 1

[Florian Quèze [:florian]]

Attachment: patch v1

Comment 2

[Daniel Brooks [:db48x]]

Comment on attachment 196550 [details] [diff] [review]
patch v1

excellent, thanks.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Tiny nitpicky nit: camelCaps is standard in at least /browser, so it should be
"computedStyle".

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 196550 [details] [diff] [review]
patch v1

fix checked in trunk by bzbarsky

Comment 5

[Mike Schroepfer]

Can you clarify on why this is needed for 1.8b5? What does it break?

Comment 6

[Florian Quèze [:florian]]

(In reply to comment #5)
> Can you clarify on why this is needed for 1.8b5? 
It isn't absolutely needed but it's a safe patch.

> What does it break?
The bug breaks the Page Info window (Forms, Links and Media tabs) on pages
containing <iframe style="display: none;">.
For example, on the homepage of http://www.clubic.com (a big french site)

Comment 7

[Mike Schroepfer]

Comment on attachment 196550 [details] [diff] [review]
patch v1

Per bug meeting - approved for 1.8b5 branch.

Comment 8

[Florian Quèze [:florian]]

fix checked in the 1.8 branch by db48x