Closed Bug 309061 Opened 19 years ago Closed 19 years ago

msgHdrViewOverlay.js should use hasChildNodes

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Once the fix to bug 240633 landed one of the changes made to TB was
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=msgHdrViewOverlay.js&branch=&root=/cvsroot&subdir=mozilla/mail/base/content&command=DIFF_FRAMESET&rev1=1.18&rev2=1.19

This is the equivalent bug for mailnews
This patch:
* Changes to using hasChildNodes()
Assignee: mail → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #196568 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 196568 [details] [diff] [review]
Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)

r+sr=me
Attachment #196568 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 196568 [details] [diff] [review]
Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)

Checking in
mozilla/mailnews/base/resources/content/msgHdrViewOverlay.js;
new revision: 1.143; previous revision: 1.142
done
Attachment #196568 - Attachment description: Use hasChildNodes patch v0.1 → Use hasChildNodes patch v0.1 (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #196568 - Flags: approval-seamonkey1.0?
Comment on attachment 196568 [details] [diff] [review]
Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)

first a=me
Attachment #196568 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+
Comment on attachment 196568 [details] [diff] [review]
Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch)
msgHdrViewOverlay.js;
new revision: 1.141.2.3; previous revision: 1.141.2.2
done
Attachment #196568 - Attachment description: Use hasChildNodes patch v0.1 (Checked in) → Use hasChildNodes patch v0.1 (Checked in trunk/branch)
Keywords: fixed1.8
Comment on attachment 196568 [details] [diff] [review]
Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8.0)
msgHdrViewOverlay.js;
new revision: 1.141.2.1.2.2; previous revision: 1.141.2.1.2.1
done
Attachment #196568 - Attachment description: Use hasChildNodes patch v0.1 (Checked in trunk/branch) → Use hasChildNodes patch v0.1 (Checked in trunk/branch 1.8 & 1.8.0)
Verified FIXED using build 2006-01-06-09 of trunk SeaMonkey under Windows XP.

No apparent regressions, and the feature works...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: