Last Comment Bug 309395 - scrollwheel doesn't work in non-toplevel window
: scrollwheel doesn't work in non-toplevel window
: fixed1.8
Product: Core Graveyard
Classification: Graveyard
Component: Widget: Mac (show other bugs)
: Trunk
: PowerPC Mac OS X
: -- normal with 1 vote (vote)
: ---
Assigned To: Mark Mentovai
: 236909 312892 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2005-09-20 16:16 PDT by Josh Aas
Modified: 2009-11-21 15:09 PST (History)
5 users (show)
asa: blocking1.8b5+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (1.46 KB, patch)
2005-09-20 16:39 PDT, Mark Mentovai
asaf: review+
sfraser_bugs: superreview+
asa: approval1.8b5+
Details | Diff | Splinter Review

Description Josh Aas 2005-09-20 16:16:45 PDT
If you open the "Report Broken Web Site" tool, you can't scroll any of the
iframe elements with a scrollwheel (license agreement, submitted report view at
the end of the wizard). Also, you can't scroll the hierarchy view when adding a
Comment 1 Mark Mentovai 2005-09-20 16:25:06 PDT
Not an iframe issue, a window type issue.  In nsMacWindow, the scroll CE handler
is only registered if mWindowType == eWindowType_toplevel.

Scroll wheel support was added by pinkerton in rev 1.95 of nsMacWindow.cpp, bug
71045.  There's your daily blast from the past.  There doesn't appear to be a
good reason for it to be in the conditional, other than that it was a convenient
place to add the code.  I'm either going to remove the conditional (installing
the handler regardless of window type) or expand the list of window types that
get the handler.
Comment 2 Mark Mentovai 2005-09-20 16:39:21 PDT
Created attachment 196852 [details] [diff] [review]

This installs the scroll wheel event handler on all window types except
invisible, plugin, and java.  For the bug reported here, it needs to be on
dialog, and for the bookmark add UI, it needs to be on sheet.  Note that popup
gives scroll wheel control of <select> elements.
Comment 3 Mano (::mano, needinfo? for any questions; not reading general bugmail) 2005-09-20 16:51:04 PDT
Comment on attachment 196852 [details] [diff] [review]

Comment 4 Mark Mentovai 2005-09-20 17:18:36 PDT
Time from open to close = 1 hour.  That includes 15 minutes I spent on the bus.
Comment 5 Scott MacGregor 2005-09-21 10:28:05 PDT
This is a pretty noticeable issue on the Mac. I recommend that we take this fix
for 1.8b5.
Comment 6 Mark Mentovai 2005-09-22 07:57:28 PDT
Comment 7 Mano (::mano, needinfo? for any questions; not reading general bugmail) 2005-10-02 09:28:54 PDT
*** Bug 236909 has been marked as a duplicate of this bug. ***
Comment 8 Mark Mentovai 2005-10-18 15:32:15 PDT
*** Bug 312892 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.