309406 - Clear Private Data window opens in an odd location on the screen

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Josh Aas]

At least with a new profile and no browser windows open, the Clear Private Data
window opens in an odd location on the screen. Even with browser windows open,
it opens in an odd place for me.

Usually the odd place is the very top left or the very bottom right of the
screen. It seems random as to where it shows up. Should probably have the
centerscreen attribute.

Comment 1

[Josh Aas]

Because this is an easy fix and it makes Mac UI look really bad I'm nominating
this for 1.8b5

Comment 2

[Josh Aas]

Attachment: fix v1.0

Comment 3

[Asaf Romano (gone)]

Comment on attachment 197118 [details] [diff] [review]
fix v1.0


>+#ifdef XP_MACOSX
>+  // on Mac OS X we don't specify a parent window because it
>+  // makes window positioning weird in some cases
>+  ww.openWindow(null,
>+                "chrome://browser/content/sanitize.xul",
>+                "Sanitize",
>+                "chrome,titlebar,centerscreen,modal",
>+                null);
>+#else
>   ww.openWindow(aParentWindow,
>                 "chrome://browser/content/sanitize.xul",
>                 "Sanitize",
>                 "chrome,titlebar,centerscreen,modal",
>                 null);
>+#endif
> };

You should only #ifdef the first line; plus, the reason we're #ifdefing it is
because we want it to be an app-modal window (the fact that we get a
problematic app modal window instead of a sheet in the case where we do pass a
parent window is a mac widget bug we should file/fix if we're not killing mac
widget rsn).

Comment 4

[Josh Aas]

Attachment: fix v1.1

Comment 5

[Asaf Romano (gone)]

Comment on attachment 197127 [details] [diff] [review]
fix v1.1

r=mano

Comment 6

[Josh Aas]

checked in on branch and trunk

Comment 7

[Marcia Knous [:marcia]]

Looks good using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b5) Gecko/20050927 Firefox/1.4 - the Clear Private Data windows opens in
center. Adding verified keyword.

Comment 8

[Boris Zbarsky [:bzbarsky]]

So... this fix leads to some _really_ weird behavior.  See bug 464930.