Clear Private Data window opens in an odd location on the screen

RESOLVED FIXED

Status

()

RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

({verified1.8})

Trunk
PowerPC
Mac OS X
verified1.8
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

771 bytes, patch
mano
: review+
mconnor
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
At least with a new profile and no browser windows open, the Clear Private Data
window opens in an odd location on the screen. Even with browser windows open,
it opens in an odd place for me.

Usually the odd place is the very top left or the very bottom right of the
screen. It seems random as to where it shows up. Should probably have the
centerscreen attribute.
(Assignee)

Comment 1

13 years ago
Because this is an easy fix and it makes Mac UI look really bad I'm nominating
this for 1.8b5
Flags: blocking1.8b5?
(Assignee)

Comment 2

13 years ago
Created attachment 197118 [details] [diff] [review]
fix v1.0
Attachment #197118 - Flags: review?(bugs.mano)
Comment on attachment 197118 [details] [diff] [review]
fix v1.0


>+#ifdef XP_MACOSX
>+  // on Mac OS X we don't specify a parent window because it
>+  // makes window positioning weird in some cases
>+  ww.openWindow(null,
>+                "chrome://browser/content/sanitize.xul",
>+                "Sanitize",
>+                "chrome,titlebar,centerscreen,modal",
>+                null);
>+#else
>   ww.openWindow(aParentWindow,
>                 "chrome://browser/content/sanitize.xul",
>                 "Sanitize",
>                 "chrome,titlebar,centerscreen,modal",
>                 null);
>+#endif
> };

You should only #ifdef the first line; plus, the reason we're #ifdefing it is
because we want it to be an app-modal window (the fact that we get a
problematic app modal window instead of a sheet in the case where we do pass a
parent window is a mac widget bug we should file/fix if we're not killing mac
widget rsn).
Attachment #197118 - Flags: review?(bugs.mano) → review-
(Assignee)

Comment 4

13 years ago
Created attachment 197127 [details] [diff] [review]
fix v1.1
Attachment #197118 - Attachment is obsolete: true
Attachment #197127 - Flags: review?(bugs.mano)
(Assignee)

Updated

13 years ago
Attachment #197127 - Flags: superreview?(mconnor)

Updated

13 years ago
Attachment #197127 - Flags: superreview?(mconnor) → superreview+

Updated

13 years ago
Flags: blocking1.8b5? → blocking1.8b5+
(Assignee)

Updated

13 years ago
Attachment #197127 - Flags: approval1.8b5?

Updated

13 years ago
Attachment #197127 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 6

13 years ago
checked in on branch and trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Looks good using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b5) Gecko/20050927 Firefox/1.4 - the Clear Private Data windows opens in
center. Adding verified keyword.
Keywords: fixed1.8 → verified1.8
So... this fix leads to some _really_ weird behavior.  See bug 464930.
You need to log in before you can comment on or make changes to this bug.