The default bug view has changed. See this FAQ.

Start of equations and diagrams not indicated in accessible tree

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
Disability Access APIs
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, fixed1.8, sec508})

Trunk
mozilla1.8beta5
x86
Windows XP
access, fixed1.8, sec508
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ETA: need review ])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Currently MathML and SVG content is available via ISimpleDOMNode, but there is
no way while reading the MSAA tree to know that content has begun.

We can expose a <math> element as ROLE_EQUATION, and an
                <svg> element as ROLE_DIAGRAM
(Assignee)

Comment 1

12 years ago
Test cases:
MathML: http://www.mozilla.org/projects/mathml/demo/texvsmml.xhtml
SVG: http://www.croczilla.com/svg/samples/events1/events1.xml
(Assignee)

Comment 2

12 years ago
Created attachment 196937 [details] [diff] [review]
Simple patch to expose ROLE_EQUATION for <math> or ROLE_DIAGRAM for <svg>

The screen reader can look at the DOM children of these IAccessibles by using
ISimpleDOMNode (QI to that from IAccessible)
Attachment #196937 - Flags: review?(parente)

Comment 3

12 years ago
Comment on attachment 196937 [details] [diff] [review]
Simple patch to expose ROLE_EQUATION for <math> or ROLE_DIAGRAM for <svg>

Is the comment block a few lines up in nsAccessibilityService still valid? Says
tags that aren't html, have tab index, or have an XHTML2 role aren't in the
accessible tree. math and svg are exceptions?

Is putting the implementation of GetRole in nsBaseWidgetAccessible.h
recommended?
Attachment #196937 - Flags: review?(parente) → review+
(Assignee)

Comment 4

12 years ago
Comment on attachment 196937 [details] [diff] [review]
Simple patch to expose ROLE_EQUATION for <math> or ROLE_DIAGRAM for <svg>

Good catch on the comment. I don't think it matters if we do inline methods for
really simple stuff. We do that all over the place in Gecko.
Attachment #196937 - Flags: superreview?(tor)
(Assignee)

Updated

12 years ago
Target Milestone: --- → mozilla1.8beta5
(Assignee)

Updated

12 years ago
Attachment #196937 - Flags: superreview?(tor)
(Assignee)

Comment 5

12 years ago
Created attachment 197612 [details] [diff] [review]
Changes to nsAccessibilityService: 1) Check namespace of <svg> and <math>, 2) Always use role to create object unless special role=presentation, 3) Remove unnecessary arg from GetRole()
Attachment #197612 - Flags: superreview?(tor)
Attachment #197612 - Flags: review?(parente)
(Assignee)

Updated

12 years ago
Attachment #197612 - Attachment is obsolete: true
Attachment #197612 - Flags: superreview?(tor)
Attachment #197612 - Flags: review?(parente)
(Assignee)

Comment 6

12 years ago
Created attachment 197615 [details] [diff] [review]
Changes to nsAccessibilityService: 1) Check namespace of <svg> and <math>, 2) Always use role to create object unless special role=presentation, 3) Remove unnecessary arg from GetRole()
Attachment #197615 - Flags: superreview?(tor)
Attachment #197615 - Flags: review?(parente)

Comment 7

12 years ago
Comment on attachment 197615 [details] [diff] [review]
Changes to nsAccessibilityService: 1) Check namespace of <svg> and <math>, 2) Always use role to create object unless special role=presentation, 3) Remove unnecessary arg from GetRole()

What are objects with roles ending in :presentation?
Attachment #197615 - Flags: review?(parente) → review+
(Assignee)

Comment 8

12 years ago
(In reply to comment #7)
> (From update of attachment 197615 [details] [diff] [review] [edit])
> What are objects with roles ending in :presentation?

That's the DHTML a11y way of removing an object from the accessibility
hierarchy. The author is saying that it is there for presentation only. Thus
<table xhtml2:role="wairole:presentation"> is a table used only for layout, not
for data.

(Assignee)

Updated

12 years ago
Whiteboard: [ETA: need review ]

Updated

12 years ago
Attachment #197615 - Flags: superreview?(tor) → superreview+
(Assignee)

Updated

12 years ago
Attachment #197615 - Flags: approval1.8b5?
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Attachment #197615 - Flags: approval1.8b5? → approval1.8b5+

Comment 9

12 years ago
Comment on attachment 197615 [details] [diff] [review]
Changes to nsAccessibilityService: 1) Check namespace of <svg> and <math>, 2) Always use role to create object unless special role=presentation, 3) Remove unnecessary arg from GetRole()

we're now locked down and in ship mode for 1.8b5. If you'd like to re-request
approval for this change, please set the approval1.8rc1? flag.
Attachment #197615 - Flags: approval1.8b5+ → approval1.8b5-
(Assignee)

Comment 10

12 years ago
Sorry, this was checked into the branch on 9/30 (fixed in 10/1 build).
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.