309523 - Sort out whether plugins should be instantiatable via file extensions

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 1156 added this XXX comment in nsObjectLoadingContent.cpp:
>+  // XXX do plugins expect to work via extension too?

This needs to be sorted out one way or another (ideally by just removing that
comment)

Comment 1

[Boris Zbarsky [:bzbarsky]]

So I was thinking....  If there is a type attribute, people really have no
excuse for wanting the extension.  So the only thing that matters is the "no
type attribute" case.

In this case, we go out to the network, right?  And things like file:// will
already use extensions... So the only question is HTTP and such....

If I read the old code correctly, we just passed stuff in to
nsPluginHostImpl::SetUpPluginInstance, right?  And that does:

3850   // if don't have a mimetype or no plugin can handle this mimetype
3851   // check by file extension
3852   if(!aMimeType || NS_FAILED(IsPluginEnabledForType(aMimeType))) {
...
3862         NS_FAILED(IsPluginEnabledForExtension(fileExtension.get(),
3863                                               mimetype))) {

Comment 2

[Boris Zbarsky [:bzbarsky]]

biesi, should this be considered for 1.9 blocking?

Comment 3

[Boris Zbarsky [:bzbarsky]]

I think this should be at least wanted.  We need to sit down and figure out whether this causes regressions for popular plugins/sites.

That is, making the code change is not a blocker.  Deciding whether we need to make the code change should be.

Renominating.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Fair enough

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 347736 has a patch for this

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

That's checked in now; it made plugins instantiatable by extensions for <embed> but not for <object>. I think that should be fine.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: remove the XXX comment

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.49; previous revision: 1.48
done