309694 - chrome windows cannot resize or maximize

Status: RESOLVED DUPLICATE of bug 277798

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Shane Caraveo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Our bug on this issue is at:
http://bugs.activestate.com/show_bug.cgi?id=40904

Below is a copy of the details.  What I would like to figure out is, is this a
bug in nsWindowWatcher.cpp?  My patch will be attached.

(the following is from the bug link above)
we install the browser chrome, which installes a command line handler
(nsBrowserContentHandler.js). This intercepts the command line and handles
opening the main window of the application. It ends up opening our chrome with
the window features "chrome,dialog=no,all".

Logic in nsWindowWatcher.cpp considers any window opening that does not include
arguments to *not* be a dialog in a certain sence. See
nsWindowWatcher::CalculateChromeFlags and nsWindowWatcher::OpenWindow.

OpenWindow sets aDialog (used in CalculateChromeFlags) only if there are
arguments in the open call, which in our case there is not. Since aDialog is
false, the "all" feature is ignored, and the result is that we do not get resize
or maximize capability.

Bug or not?

One way to fix this is to create our own command line handler class, and(?)
remove the browser chrome handler. I'm not sure what order command line handlers
get used.

Another way to fix this is to have CalculateChromeFlags recognize the "all"
feature irregardless of the window getting arguments. This is my current approach.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Shane Caraveo]

Attachment: patch to recognize "all" feature

This patch fixes our issue specificly.	This may also end up being an issue for
xulrunner.

Comment 2

[Boris Zbarsky [:bzbarsky]]

danm, how's this feature stuff supposed to work again, do you recall?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Confirming bug.  Danm seems to be missing in action; Neil or Mike, do you know
what should be happening here?

Comment 4

[Benjamin Smedberg]

*** This bug has been marked as a duplicate of 277798 ***