309702 - Crashes when adblocking is enabled [@ nsPluginStreamListener::OnStartRequest]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Hiro]

Incident ID: TB9634495X, TB9634658E, TB9634714G

It crashes by some pages when adblock is enable.

Reproducible: Always

Steps to Reproduce:
1. Adblock is turned on with Preferences. 
2. open URL
3. The following links are clicked with a left frame. 
   http://live16.2ch.net/liventv/


Mac OS X 10.3.9
trunk build: 2005092208 (v1.0+)

Comment 1

[Hiro]

Attachment: crash log

Comment 2

[Mike Pinkerton (not reading bugmail)]

the crash is in the plugin code. why would ad blocking affect that?

Comment 3

[Simon Fraser [no longer active]]

(In reply to comment #2)
> the crash is in the plugin code. why would ad blocking affect that?

Maybe we block a Flash plugin, and an iframe ends up with no content or something.

I wasn't able to find the liventv link in the left frame (too many links!).

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: possible patch

this should fix it, I believe...

Comment 5

[Simon Fraser [no longer active]]

Can we at least get a testcase?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: testcase (crashes current trunk)

Testcase. This crashes in nsPluginStreamListener::OnStartRequest so I believe
it's this bug. (any my patch does fix it)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/html/document/src/nsPluginDocument.cpp;
/cvsroot/mozilla/content/html/document/src/nsPluginDocument.cpp,v  <-- 
nsPluginDocument.cpp
new revision: 1.23; previous revision: 1.22
done

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

(what I fixed was caused by bug 1156)

Comment 9

[Simon Fraser [no longer active]]

Do we need this on the branch?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

no, bug 1156 was trunk only.