Status
People
(Reporter: thesuckiestemail, Assigned: thesuckiestemail)
Tracking
({fixed1.8})
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 2 obsolete attachments)
26.01 KB,
patch
|
sergei_d
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
The current version has a poor init and the codestyle is quite weird in some places.
Created attachment 197447 [details] [diff] [review] Cleanup, and rewritten init Hopefully this patch is already good, it was quite a big file so I may have missed something.
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Comment on attachment 197447 [details] [diff] [review] Cleanup, and rewritten init r?
Attachment #197447 -
Flags: review?(sergei_d)
Created attachment 197464 [details] [diff] [review] Updated according to comments Better checks in init, removed comments and changed order on mClipRegion nullcheck (although not important).
Attachment #197447 -
Attachment is obsolete: true
Created attachment 197469 [details] [diff] [review] Second init improved
Attachment #197464 -
Attachment is obsolete: true
Attachment #197469 -
Flags: review?(sergei_d)
Comment 5•14 years ago
|
||
Comment on attachment 197469 [details] [diff] [review] Second init improved r=sergei_d
Attachment #197469 -
Flags: review?(sergei_d) → review+
Comment 6•14 years ago
|
||
Patch landed: nsRenderingContextBeOS.cpp new revision: 1.53; previous revision: 1.52
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Comment 7•14 years ago
|
||
Comment on attachment 197469 [details] [diff] [review] Second init improved BeOS-only change. Tested, will not affect any other platform in any way. Requesting approval for MOZILLA_1_8_BRANCH
Attachment #197469 -
Flags: approval1.8b5?
Updated•14 years ago
|
Attachment #197469 -
Flags: approval1.8b5? → approval1.8b5+
Updated•14 years ago
|
Keywords: fixed1.8
Comment on attachment 197447 [details] [diff] [review] Cleanup, and rewritten init removing old review req.
Attachment #197447 -
Flags: review?(sergei_d)
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•