Closed Bug 310090 Opened 18 years ago Closed 18 years ago

[BeOS] nsRenderingContextBeOS cleanup

Categories

(Core Graveyard :: GFX: BeOS, defect)

Product:
Core Graveyard
Component:
GFX: BeOS
Platform:
Other
BeOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: thesuckiestemail, Assigned: thesuckiestemail)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file, 2 obsolete files)

Second init improved
26.01 KB, patch
sergei_d
: review+
asa
: approval1.8b5+
Details | Diff | Splinter Review 
The current version has a poor init and the codestyle is quite weird in some places.
Attached patch Cleanup, and rewritten init (obsolete) — — Splinter Review 
Hopefully this patch is already good, it was quite a big file so I may have
missed something.
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

r?
Attachment #197447 - Flags: review?(sergei_d)
Blocks: 296856
Attached patch Updated according to comments (obsolete) — — Splinter Review 
Better checks in init, removed comments and changed order on mClipRegion
nullcheck (although not important).
Attachment #197447 - Attachment is obsolete: true

    
  

        Attachment #197464 -
        Attachment is obsolete: true

        Attachment #197469 -
        Flags: review?(sergei_d)

    
    

    
  
Comment on attachment 197469 [details] [diff] [review]
Second init improved

r=sergei_d

        Attachment #197469 -
        Flags: review?(sergei_d) → review+

    
    

    
  
Patch landed:
nsRenderingContextBeOS.cpp
new revision: 1.53; previous revision: 1.52

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 197469 [details] [diff] [review]
Second init improved

BeOS-only change. Tested, will not affect any other platform in any way.
Requesting approval for MOZILLA_1_8_BRANCH

        Attachment #197469 -
        Flags: approval1.8b5?

    
  

        Attachment #197469 -
        Flags: approval1.8b5? → approval1.8b5+

    
  
Keywords: fixed1.8

    
    

    
  
Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

removing old review req.

        Attachment #197447 -
        Flags: review?(sergei_d)
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.