310090 - [BeOS] nsRenderingContextBeOS cleanup

Status: RESOLVED FIXED

Description

[tqh]

The current version has a poor init and the codestyle is quite weird in some places.

Comment 1

[tqh]

Created attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

Hopefully this patch is already good, it was quite a big file so I may have
missed something.

Comment 2

[tqh]

Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

r?

Comment 3

[tqh]

Created attachment 197464 [details] [diff] [review]
Updated according to comments

Better checks in init, removed comments and changed order on mClipRegion
nullcheck (although not important).

Comment 4

[tqh]

Created attachment 197469 [details] [diff] [review]
Second init improved

Comment 5

[Sergei Dolgov]

Comment on attachment 197469 [details] [diff] [review]
Second init improved

r=sergei_d

Comment 6

[Sergei Dolgov]

Patch landed:
nsRenderingContextBeOS.cpp
new revision: 1.53; previous revision: 1.52

Comment 7

[Niels Reedijk]

Comment on attachment 197469 [details] [diff] [review]
Second init improved

BeOS-only change. Tested, will not affect any other platform in any way.
Requesting approval for MOZILLA_1_8_BRANCH

Comment 8

[tqh]

Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

removing old review req.