Last Comment Bug 310090 - [BeOS] nsRenderingContextBeOS cleanup
: [BeOS] nsRenderingContextBeOS cleanup
Status: RESOLVED FIXED
: fixed1.8
Product: Core Graveyard
Classification: Graveyard
Component: GFX: BeOS (show other bugs)
: Trunk
: Other BeOS
: -- normal (vote)
: ---
Assigned To: tqh
: QA timeless
Mentors:
Depends on:
Blocks: 296856
  Show dependency treegraph
 
Reported: 2005-09-26 11:38 PDT by tqh
Modified: 2009-01-22 10:17 PST (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Cleanup, and rewritten init (25.98 KB, patch)
2005-09-26 11:40 PDT, tqh
no flags Details | Diff | Splinter Review
Updated according to comments (25.89 KB, patch)
2005-09-26 13:55 PDT, tqh
no flags Details | Diff | Splinter Review
Second init improved (26.01 KB, patch)
2005-09-26 14:13 PDT, tqh
sergei_d: review+
asa: approval1.8b5+
Details | Diff | Splinter Review

Description tqh 2005-09-26 11:38:42 PDT
The current version has a poor init and the codestyle is quite weird in some places.
Comment 1 tqh 2005-09-26 11:40:07 PDT
Created attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

Hopefully this patch is already good, it was quite a big file so I may have
missed something.
Comment 2 tqh 2005-09-26 11:45:50 PDT
Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

r?
Comment 3 tqh 2005-09-26 13:55:32 PDT
Created attachment 197464 [details] [diff] [review]
Updated according to comments

Better checks in init, removed comments and changed order on mClipRegion
nullcheck (although not important).
Comment 4 tqh 2005-09-26 14:13:23 PDT
Created attachment 197469 [details] [diff] [review]
Second init improved
Comment 5 Sergei Dolgov 2005-09-26 14:27:34 PDT
Comment on attachment 197469 [details] [diff] [review]
Second init improved

r=sergei_d
Comment 6 Sergei Dolgov 2005-09-26 14:32:02 PDT
Patch landed:
nsRenderingContextBeOS.cpp
new revision: 1.53; previous revision: 1.52
Comment 7 Niels Reedijk 2005-09-26 22:43:36 PDT
Comment on attachment 197469 [details] [diff] [review]
Second init improved

BeOS-only change. Tested, will not affect any other platform in any way.
Requesting approval for MOZILLA_1_8_BRANCH
Comment 8 tqh 2006-12-27 00:23:58 PST
Comment on attachment 197447 [details] [diff] [review]
Cleanup, and rewritten init

removing old review req.

Note You need to log in before you can comment on or make changes to this bug.