Closed Bug 310090 Opened 17 years ago Closed 17 years ago
OS] ns Rendering Context Be OS cleanup
The current version has a poor init and the codestyle is quite weird in some places.
Hopefully this patch is already good, it was quite a big file so I may have missed something.
Assignee: beos → thesuckiestemail
Status: NEW → ASSIGNED
Comment on attachment 197447 [details] [diff] [review] Cleanup, and rewritten init r?
Better checks in init, removed comments and changed order on mClipRegion nullcheck (although not important).
Attachment #197447 - Attachment is obsolete: true
Comment on attachment 197469 [details] [diff] [review] Second init improved r=sergei_d
Attachment #197469 - Flags: review?(sergei_d) → review+
Patch landed: nsRenderingContextBeOS.cpp new revision: 1.53; previous revision: 1.52
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment on attachment 197469 [details] [diff] [review] Second init improved BeOS-only change. Tested, will not affect any other platform in any way. Requesting approval for MOZILLA_1_8_BRANCH
Attachment #197469 - Flags: approval1.8b5?
Attachment #197469 - Flags: approval1.8b5? → approval1.8b5+
Comment on attachment 197447 [details] [diff] [review] Cleanup, and rewritten init removing old review req.
You need to log in before you can comment on or make changes to this bug.