This spins off of bug 226593 Steps to reproduce: 1- Load provided URL 2- Click the "All borders" button Actual results: table rules are not visible Expected results: table rules are visible
Dynamic changes aren't even needed; it looks like we just broke rules="all" for the case when the table has no border set -- this is a regression from bug 155507. The problem is that the only reason rules="all" worked is that the post-resolve callbacks in nsHTMLStyleSheet mapped border styles onto table rows, cols, and colgroups. Now that we're not collapsing borders for rules="all", this does absolutely nothing, of course... For 1.9 we should just work on fixing bug 43178, but for 1.8 I see a few options, I guess: 1) Back out the patch for bug 155507. 2) Add a post-resolve callback for table cells (and probably remove the existing ones) 3) Fix bug 43178 for 1.8 (this kinda scares me, to be truthful). 4) Leave this broken in 1.8 and tell people to set the border (I'm not happy with this approach, frankly). Did I miss anything? David, option #3 sounds best to me if you think it wouldn't be too slow...
Created attachment 197501 [details] [diff] [review] Patch It's probably better to back this part out for now, pending bug 43178 being fixed.
Comment on attachment 197501 [details] [diff] [review] Patch Boris, sorry but I am to lame to get these things fixed in a timely manner.
Fixed on trunk.
Comment on attachment 197501 [details] [diff] [review] Patch Requesting 1.8b5 approval. This just fixes a regression by backing out part of a patch... It's not great, but the best we can do in the 1.8 timeframe at this point, I think.