rules="all" does not work when table has no border

RESOLVED FIXED in mozilla1.8beta5

Status

()

Core
Layout: Tables
P1
major
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Gérard Talbot, Assigned: bz)

Tracking

({fixed1.8, regression, testcase})

Trunk
mozilla1.8beta5
fixed1.8, regression, testcase
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
This spins off of bug 226593

Steps to reproduce:
1- Load provided URL
2- Click the "All borders" button

Actual results: table rules are not visible

Expected results: table rules are visible
(Reporter)

Updated

12 years ago
Keywords: regression
Dynamic changes aren't even needed; it looks like we just broke rules="all" for
the case when the table has no border set -- this is a regression from bug 155507.

The problem is that the only reason rules="all" worked is that the post-resolve
callbacks in nsHTMLStyleSheet mapped border styles onto table rows, cols, and
colgroups.  Now that we're not collapsing borders for rules="all", this does
absolutely nothing, of course...

For 1.9 we should just work on fixing bug 43178, but for 1.8 I see a few
options, I guess:

1)  Back out the patch for bug 155507.
2)  Add a post-resolve callback for table cells (and probably remove the
    existing ones)
3)  Fix bug 43178 for 1.8 (this kinda scares me, to be truthful).
4)  Leave this broken in 1.8 and tell people to set the border (I'm not happy
    with this approach, frankly).

Did I miss anything?  David, option #3 sounds best to me if you think it
wouldn't be too slow...
Severity: normal → major
Flags: blocking1.8b5?
OS: Windows XP → All
Hardware: PC → All
Summary: Dynamic changes to rules="all" does not work → rules="all" does not work when table has no border
Created attachment 197501 [details] [diff] [review]
Patch

It's probably better to back this part out for now, pending bug 43178 being
fixed.
Attachment #197501 - Flags: superreview?(dbaron)
Attachment #197501 - Flags: review?(bernd_mozilla)
Attachment #197501 - Flags: superreview?(dbaron) → superreview+

Comment 3

12 years ago
Comment on attachment 197501 [details] [diff] [review]
Patch

Boris, sorry but I am to lame to get these things fixed in a timely manner.
Attachment #197501 - Flags: review?(bernd_mozilla) → review+

Updated

12 years ago
Flags: blocking1.8b5? → blocking1.8b5+
Assignee: nobody → bzbarsky
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta5
Comment on attachment 197501 [details] [diff] [review]
Patch

Requesting 1.8b5 approval.  This just fixes a regression by backing out part of
a patch...  It's not great, but the best we can do in the 1.8 timeframe at this
point, I think.
Attachment #197501 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #197501 - Flags: approval1.8b5? → approval1.8b5+
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.