310101 - Assertion failure (nsDirPrefs) when attempting to change a ldap attribute map pref in about:config with address book open.

Status: VERIFIED FIXED

(MailNews Core :: LDAP Integration, defect)

Description

[Mark Banner (:standard8)]

Seen on:
Assertion failure: rc != idNone, at
/opt/mozmaster/mozilla/mailnews/addrbook/src/nsDirPrefs.cpp:1484

Only occurs on Debug builds (its an assertion).

The recent ldap attribute map changes have caused this to occur. When one of the
prefs is changed, it fires a callback into nsDirPrefs.cpp, nsDirPrefs.cpp
unfortunately hardcodes all the pref names, and therefore, rc = idNone in 
DIR_AtomizePrefName when it returns.

Comment 1

[Mark Banner (:standard8)]

Attachment: a fix.

Though we could really do with re-writing the function and nsDirPrefs, this
patch causes the *.attrmap.* prefs to be recongnised & therefore it will no
longer assert.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 197474 [details] [diff] [review]
a fix.

r+sr=dmose

Comment 3

[Mark Banner (:standard8)]

I checked this in earlier.
/cvsroot/mozilla/mailnews/addrbook/src/nsDirPrefs.h,v  <--  nsDirPrefs.h
new revision: 1.30; previous revision: 1.29
done
Checking in mailnews/addrbook/src/nsDirPrefs.cpp;
/cvsroot/mozilla/mailnews/addrbook/src/nsDirPrefs.cpp,v  <--  nsDirPrefs.cpp
new revision: 1.99; previous revision: 1.98

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with a semi-current, debug trunk build under Windows XP.

No asserts...

checkout start: Fri Jan 13 23:08:33 USEST 2006
cvs checkout: