310107 - Binding prototype is not unhooked at document teardown

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Brian Ryner (not reading)]

Spun off from bug 293386 comment 15 :

There's a fairly old regression where binding prototypes are not unhooked at 
document teardown as they were intended to be.  See attachment 197215 [details] for a 
testcase.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So.. I can easily fix the prototype unhooking in all cases _except_ that of
bfcache.  How do you suggest we deal with bfcache here?

Comment 2

[Brian Ryner (not reading)]

Since this all requires a script global to work, it seems like maybe we should 
listen for pagehide and detach the prototype there, then reattach it at 
pageshow if necessary.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm... Or maybe something is even more screwed up than I thought.  When I change
the check for the implementation to actually work, we end up creating a brand
new wrapper for the node in this code!  How did our old wrapper go away given
that someone's holding a ref to it?  Or why are we failing to find it, at least?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch that fixes the check for implementation

For what it's worth, for 1.9 I think we should move towards documents always
having a script global, no matter what.  That is, make the inner window have
the same exact lifetime as the document (possibly share a refcount?).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase based on the test in bug 293386

Once bug 398135 is checked in, this test can go in too.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Should be fixed by bug 398135.  Test checked in.