Closed Bug 310122 Opened 15 years ago Closed 15 years ago

XForms package should have skin directory

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Some styles should be moved into skin directory (bindingex.css and some styles
of xfroms.css)

Reproducible: Always
Any reason why?
To have a skin is generally used practice. It is skinability. If I like to
revrite some styles then I can be easier to locate styles what I need. 
(In reply to comment #2)
> To have a skin is generally used practice. It is skinability. If I like to
> revrite some styles then I can be easier to locate styles what I need. 

Well, ok. I have no use for it, but no problem with it either. If you write a
patch, then let's move it. You need to change the location in bindingex.xul and
nsXFormsModule.cpp, but nowhere else I think.
Assignee: aaronr → surkov
Here's info about how to register skins:
http://developer.mozilla.org/en/docs/Chrome_Registration

Remember to change contents.rdf too to support SeaMonkey.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch patchSplinter Review
Attachment #216728 - Flags: review?(allan)
Attachment #216728 - Flags: review?(allan) → review+
Blocks: 327584
OS: Windows 2000 → All
Hardware: PC → All
Attachment #216728 - Flags: review?(doronr)
Attachment #216728 - Flags: review?(doronr) → review+
Checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Blocks: 332853
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.