Closed
Bug 310122
Opened 19 years ago
Closed 19 years ago
XForms package should have skin directory
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: fixed1.8.0.4, fixed1.8.1)
Attachments
(1 file)
4.55 KB,
patch
|
allan
:
review+
doronr
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Some styles should be moved into skin directory (bindingex.css and some styles
of xfroms.css)
Reproducible: Always
Comment 1•19 years ago
|
||
Any reason why?
Assignee | ||
Comment 2•19 years ago
|
||
To have a skin is generally used practice. It is skinability. If I like to
revrite some styles then I can be easier to locate styles what I need.
Comment 3•19 years ago
|
||
(In reply to comment #2)
> To have a skin is generally used practice. It is skinability. If I like to
> revrite some styles then I can be easier to locate styles what I need.
Well, ok. I have no use for it, but no problem with it either. If you write a
patch, then let's move it. You need to change the location in bindingex.xul and
nsXFormsModule.cpp, but nowhere else I think.
Assignee | ||
Updated•19 years ago
|
Assignee: aaronr → surkov
Comment 4•19 years ago
|
||
Here's info about how to register skins:
http://developer.mozilla.org/en/docs/Chrome_Registration
Remember to change contents.rdf too to support SeaMonkey.
Assignee | ||
Updated•19 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 5•19 years ago
|
||
Attachment #216728 -
Flags: review?(allan)
Updated•19 years ago
|
Attachment #216728 -
Flags: review?(allan) → review+
Updated•19 years ago
|
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Updated•19 years ago
|
Attachment #216728 -
Flags: review?(doronr)
Updated•19 years ago
|
Attachment #216728 -
Flags: review?(doronr) → review+
Comment 6•19 years ago
|
||
Checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Updated•19 years ago
|
Keywords: fixed1.8.0.3,
fixed1.8.1
Updated•19 years ago
|
Whiteboard: xf-to-branch
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•