310122 - XForms package should have skin directory

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Some styles should be moved into skin directory (bindingex.css and some styles
of xfroms.css)

Reproducible: Always

Comment 1

[Allan Beaufour]

Any reason why?

Comment 2

[alexander :surkov (:asurkov)]

To have a skin is generally used practice. It is skinability. If I like to
revrite some styles then I can be easier to locate styles what I need. 

Comment 3

[Allan Beaufour]

(In reply to comment #2)
> To have a skin is generally used practice. It is skinability. If I like to
> revrite some styles then I can be easier to locate styles what I need. 

Well, ok. I have no use for it, but no problem with it either. If you write a
patch, then let's move it. You need to change the location in bindingex.xul and
nsXFormsModule.cpp, but nowhere else I think.

Comment 4

[Allan Beaufour]

Here's info about how to register skins:
http://developer.mozilla.org/en/docs/Chrome_Registration

Remember to change contents.rdf too to support SeaMonkey.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[Allan Beaufour]

Checked into trunk.