XForms package should have skin directory

RESOLVED FIXED

Status

RESOLVED FIXED
14 years ago
3 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
fixed1.8.0.4, fixed1.8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Some styles should be moved into skin directory (bindingex.css and some styles
of xfroms.css)

Reproducible: Always

Comment 1

14 years ago
Any reason why?
(Assignee)

Comment 2

14 years ago
To have a skin is generally used practice. It is skinability. If I like to
revrite some styles then I can be easier to locate styles what I need. 

Comment 3

14 years ago
(In reply to comment #2)
> To have a skin is generally used practice. It is skinability. If I like to
> revrite some styles then I can be easier to locate styles what I need. 

Well, ok. I have no use for it, but no problem with it either. If you write a
patch, then let's move it. You need to change the location in bindingex.xul and
nsXFormsModule.cpp, but nowhere else I think.
(Assignee)

Updated

13 years ago
Assignee: aaronr → surkov

Comment 4

13 years ago
Here's info about how to register skins:
http://developer.mozilla.org/en/docs/Chrome_Registration

Remember to change contents.rdf too to support SeaMonkey.
(Assignee)

Updated

13 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 5

13 years ago
Created attachment 216728 [details] [diff] [review]
patch
Attachment #216728 - Flags: review?(allan)

Updated

13 years ago
Attachment #216728 - Flags: review?(allan) → review+

Updated

13 years ago
Blocks: 327584

Updated

13 years ago
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Updated

13 years ago
Attachment #216728 - Flags: review?(doronr)
Attachment #216728 - Flags: review?(doronr) → review+

Comment 6

13 years ago
Checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch

Updated

13 years ago
Blocks: 332853

Updated

13 years ago
Keywords: fixed1.8.0.3, fixed1.8.1

Updated

13 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.