310291 - Sidebar max-width shouldn't be in px, consistency with the Go menu

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Thomas Bertels]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8b4) Gecko/20050906 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8b4) Gecko/20050906 Firefox/1.4

The sidebar max-width is 400px, what means that users wich use large or very
large fonts won't be able to read the full titles of the bookmarks.
The Go menu max-width is set to 50em, so why not the same max-width for the
sidebar ?

Reproducible: Always

Steps to Reproduce:

Comment 1

[Thomas Bertels]

Attachment: Sidebar max-width to 50em

Comment 2

[Ria Klaassen (not reading all bugmail)]

This is a very good idea. :)

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 197684 [details] [diff] [review]
Sidebar max-width to 50em

If you're going to do one in em, convert all of them.  Also, what font size are
you using a base for the conversion?  We shouldn't change things if possible
for the default font size.

Comment 4

[Thomas Bertels]

Attachment: Consistant with the Go menu, better for subfolders (max-width:50em)

Determined with default font size.
The 50em max-width is the same as the Go menu, it's also better when using
subfolders.

Comment 5

[Thomas Bertels]

Attachment: (max-width:36em)

This one keeps the same sizes as the ones in px, the max-width is perhaps too
narrow, especially for users of subfolders or who use high resolution screens.
Or would an horizontal scrollbar be better than max-width:50em?

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 198295 [details] [diff] [review]
(max-width:36em)

I think this is big enough.  I have a 1920x1200 monitor, and the existing sidebar is plenty big enough for sidebar-friendly content.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 198295 [details] [diff] [review]
(max-width:36em)

Makes sense to me.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Fixed on the trunk and 1.8 branch for Firefox 2.
mozilla/browser/base/content/browser.xul; new revision: 1.278;
mozilla/browser/base/content/browser.xul; new revision: 1.268.2.11;