Closed Bug 310293 Opened 15 years ago Closed 15 years ago

[BeOS] Cannot open menus after workspace change.

Categories

(Core Graveyard :: Widget: BeOS, defect)

x86
BeOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sergei_d, Assigned: sergei_d)

References

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

843 bytes, patch
Details | Diff | Splinter Review
Open some menu from menu bar.
Bring browser to another workspace.
Try to open menu. No luck.

Reason - menus seems to be rather hidden than destroyed in "closing". So they
stay in old workspace.

Remedy - when unhiding popups, bring those always to current workspace.
It is also may be good idea to bring there non-popup dependent windows, like
Preferences, History etc, but it seems much more complicated task. We should
consult Unix people, who are also dealing with multiple workspaces.
Attached patch Patch. (obsolete) — Splinter Review
Bringing popup to current workspace before Show()
Attachment #197687 - Flags: review?(thesuckiestemail)
Comment on attachment 197687 [details] [diff] [review]
Patch.

r=thesuckiestemail@yahoo.se
Attachment #197687 - Flags: review?(thesuckiestemail) → review+
Blocks: 266252
Landed in trunk.
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.96; previous revision: 1.95 
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 197687 [details] [diff] [review]
Patch.

BeOS only change. won't affect any other platforms. Requesting approval for the
1.8 branch.
Attachment #197687 - Flags: approval1.8b5?
Comment on attachment 197687 [details] [diff] [review]
Patch.

extra }, sorry. Build bustage.
Trunk fixed
new revision: 1.97; previous revision: 1.96 

submitting fixed patch for 1.8* soon
Attachment #197687 - Attachment is obsolete: true
Attached patch patchSplinter Review
removed extra }
Nielx, please test it again before 1.8* commit (if patch applies cleanly and
builds ok).
I'm very sorry
Attachment #197687 - Flags: approval1.8b5? → approval1.8b5+
Checking in widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.5; previous revision: 1.91.4.4
done
did this land on the branch? If so, please add the fixed1.8 keyword. If not,
then it didn't make 1.8b5 so please request approval for rc1 if you think it's
warranted.
Keywords: fixed1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.