310293 - [BeOS] Cannot open menus after workspace change.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: BeOS, defect)

Description

[Sergei Dolgov]

Open some menu from menu bar.
Bring browser to another workspace.
Try to open menu. No luck.

Reason - menus seems to be rather hidden than destroyed in "closing". So they
stay in old workspace.

Remedy - when unhiding popups, bring those always to current workspace.
It is also may be good idea to bring there non-popup dependent windows, like
Preferences, History etc, but it seems much more complicated task. We should
consult Unix people, who are also dealing with multiple workspaces.

Comment 1

[Sergei Dolgov]

Attachment: Patch.

Bringing popup to current workspace before Show()

Comment 2

[tqh]

Comment on attachment 197687 [details] [diff] [review]
Patch.

r=[e-mail]

Comment 3

[Sergei Dolgov]

Landed in trunk.
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.96; previous revision: 1.95 

Comment 4

[Niels Reedijk]

Comment on attachment 197687 [details] [diff] [review]
Patch.

BeOS only change. won't affect any other platforms. Requesting approval for the
1.8 branch.

Comment 5

[Sergei Dolgov]

Comment on attachment 197687 [details] [diff] [review]
Patch.

extra }, sorry. Build bustage.
Trunk fixed
new revision: 1.97; previous revision: 1.96 

submitting fixed patch for 1.8* soon

Comment 6

[Sergei Dolgov]

Attachment: patch

removed extra }
Nielx, please test it again before 1.8* commit (if patch applies cleanly and
builds ok).
I'm very sorry

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Checking in widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.91.4.5; previous revision: 1.91.4.4
done

Comment 8

[Asa Dotzler [:asa]]

did this land on the branch? If so, please add the fixed1.8 keyword. If not,
then it didn't make 1.8b5 so please request approval for rc1 if you think it's
warranted.