Closed Bug 310473 Opened 15 years ago Closed 15 years ago

Avoid passing noninvertable matrices to cairo

Categories

(Core :: SVG, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tor, Assigned: tor)

Details

(Keywords: fixed1.8)

Attachments

(2 files, 2 obsolete files)

Cairo treats being passed a noninvertable matrix as an API error, which causes
the cairo object to stop rendering at that point.  Need to add some checks so
that we can continue gracefully.
Attached patch matrix checks (obsolete) — Splinter Review
Attachment #197868 - Flags: review?(scootermorris)
Attached patch corresponding branch patch (obsolete) — Splinter Review
Attachment #197868 - Flags: review?(scootermorris)
Attachment #197868 - Attachment is obsolete: true
Attachment #198054 - Flags: review?(jonathan.watt)
Attachment #197954 - Attachment is obsolete: true
Attachment #198056 - Flags: review?(jonathan.watt)
Comment on attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case

That looks good now. r=me
Attachment #198054 - Flags: review?(jonathan.watt) → review+
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

r=me
Attachment #198056 - Flags: review?(jonathan.watt) → review+
Checked in on trunk.
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

Specification compliance bug, and prevents us from handing cairo a matrix it
can't deal with.  Minimal risk.
Attachment #198056 - Flags: approval1.8b5?
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

last day for non-critical changes.
Attachment #198056 - Flags: approval1.8b5? → approval1.8b5+
Checked in on branch.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.