Avoid passing noninvertable matrices to cairo

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

({fixed1.8})

Trunk
x86
Linux
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

12 years ago
Cairo treats being passed a noninvertable matrix as an API error, which causes
the cairo object to stop rendering at that point.  Need to add some checks so
that we can continue gracefully.
(Assignee)

Comment 1

12 years ago
Created attachment 197868 [details] [diff] [review]
matrix checks
Attachment #197868 - Flags: review?(scootermorris)
(Assignee)

Comment 2

12 years ago
Created attachment 197954 [details] [diff] [review]
corresponding branch patch
(Assignee)

Updated

12 years ago
Attachment #197868 - Flags: review?(scootermorris)
(Assignee)

Comment 3

12 years ago
Created attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case
Attachment #197868 - Attachment is obsolete: true
Attachment #198054 - Flags: review?(jonathan.watt)
(Assignee)

Comment 4

12 years ago
Created attachment 198056 [details] [diff] [review]
corresponding branch patch
Attachment #197954 - Attachment is obsolete: true
Attachment #198056 - Flags: review?(jonathan.watt)
Comment on attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case

That looks good now. r=me
Attachment #198054 - Flags: review?(jonathan.watt) → review+
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

r=me
Attachment #198056 - Flags: review?(jonathan.watt) → review+
(Assignee)

Comment 7

12 years ago
Checked in on trunk.
(Assignee)

Comment 8

12 years ago
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

Specification compliance bug, and prevents us from handing cairo a matrix it
can't deal with.  Minimal risk.
Attachment #198056 - Flags: approval1.8b5?

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 9

12 years ago
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

last day for non-critical changes.
Attachment #198056 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 10

12 years ago
Checked in on branch.
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.