Closed
Bug 310473
Opened 20 years ago
Closed 20 years ago
Avoid passing noninvertable matrices to cairo
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
Details
(Keywords: fixed1.8)
Attachments
(2 files, 2 obsolete files)
|
14.92 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
|
11.07 KB,
patch
|
jwatt
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
Cairo treats being passed a noninvertable matrix as an API error, which causes
the cairo object to stop rendering at that point. Need to add some checks so
that we can continue gracefully.
Attachment #197868 -
Flags: review?(scootermorris)
Attachment #197868 -
Flags: review?(scootermorris)
Attachment #197868 -
Attachment is obsolete: true
Attachment #198054 -
Flags: review?(jonathan.watt)
Attachment #197954 -
Attachment is obsolete: true
Attachment #198056 -
Flags: review?(jonathan.watt)
|
||
Comment 5•20 years ago
|
||
Comment on attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case
That looks good now. r=me
Attachment #198054 -
Flags: review?(jonathan.watt) → review+
|
|
||
Comment 6•20 years ago
|
||
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch
r=me
Attachment #198056 -
Flags: review?(jonathan.watt) → review+
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch
Specification compliance bug, and prevents us from handing cairo a matrix it
can't deal with. Minimal risk.
Attachment #198056 -
Flags: approval1.8b5?
|
|
||
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 9•20 years ago
|
||
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch
last day for non-critical changes.
Attachment #198056 -
Flags: approval1.8b5? → approval1.8b5+
You need to log in
before you can comment on or make changes to this bug.
Description
•