Last Comment Bug 310473 - Avoid passing noninvertable matrices to cairo
: Avoid passing noninvertable matrices to cairo
Status: RESOLVED FIXED
: fixed1.8
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: tor
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-29 10:07 PDT by tor
Modified: 2005-10-03 13:31 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
matrix checks (13.88 KB, patch)
2005-09-29 10:08 PDT, tor
no flags Details | Diff | Splinter Review
corresponding branch patch (10.18 KB, patch)
2005-09-29 19:51 PDT, tor
no flags Details | Diff | Splinter Review
trunk - fix leaks, add missing case (14.92 KB, patch)
2005-09-30 14:57 PDT, tor
jwatt: review+
Details | Diff | Splinter Review
corresponding branch patch (11.07 KB, patch)
2005-09-30 14:58 PDT, tor
jwatt: review+
asa: approval1.8b5+
Details | Diff | Splinter Review

Description tor 2005-09-29 10:07:19 PDT
Cairo treats being passed a noninvertable matrix as an API error, which causes
the cairo object to stop rendering at that point.  Need to add some checks so
that we can continue gracefully.
Comment 1 tor 2005-09-29 10:08:10 PDT
Created attachment 197868 [details] [diff] [review]
matrix checks
Comment 2 tor 2005-09-29 19:51:18 PDT
Created attachment 197954 [details] [diff] [review]
corresponding branch patch
Comment 3 tor 2005-09-30 14:57:29 PDT
Created attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case
Comment 4 tor 2005-09-30 14:58:32 PDT
Created attachment 198056 [details] [diff] [review]
corresponding branch patch
Comment 5 Jonathan Watt [:jwatt] (catching up after vacation) 2005-10-02 09:01:23 PDT
Comment on attachment 198054 [details] [diff] [review]
trunk - fix leaks, add missing case

That looks good now. r=me
Comment 6 Jonathan Watt [:jwatt] (catching up after vacation) 2005-10-02 09:01:46 PDT
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

r=me
Comment 7 tor 2005-10-02 12:35:51 PDT
Checked in on trunk.
Comment 8 tor 2005-10-02 12:37:00 PDT
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

Specification compliance bug, and prevents us from handing cairo a matrix it
can't deal with.  Minimal risk.
Comment 9 Asa Dotzler [:asa] 2005-10-03 10:49:00 PDT
Comment on attachment 198056 [details] [diff] [review]
corresponding branch patch

last day for non-critical changes.
Comment 10 tor 2005-10-03 13:31:11 PDT
Checked in on branch.

Note You need to log in before you can comment on or make changes to this bug.