310480 - Submenu of context menu doesn't open automatically when highlighted

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Nikola Kocić]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050929 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050929 Firefox/1.4

Right click submenu do not automaticaly open when highlighted (for instance
FlashGot and BBCode submenus). You must click on it to show it up.

Reproducible: Always

Steps to Reproduce:
1. Install FlashGot extension
2. Make right click on the page
3. Highlight "FlashGot Options"
Actual Results:  
You need to click on submenu to activate it

Expected Results:  
Submenu appears after highlghtning

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) Gecko/20050929
Firefox/1.4 ID:2005092901

Confirmed
->NEW / regression

also happens in framed page
1.rightclick for context menu
2.highlight "this frame"
it won't expand unless you click on it

brb with usefull regressionrange

Comment 2

[RS]

Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8b5) Gecko/20050929
Firefox/1.4 - Build ID: 2005092906

Same on Windows ME.

Comment 3

[Peter van der Woude [:Peter6]]

regressionrange
works in 20050928 1058 pdt build
fails in 20050928 1236 pdt build

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=AviarySuiteBranchTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-28+10%3A14%3A00&maxdate=2005-09-28+11%3A51%3A00&cvsroot=%2Fcvsroot

my money on bug 203183

cc vlad

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Looking; might not get a fix in until this evening, though.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 310480-context-menu-submenus-fix.patch

This fixes it for me; I've no idea why this didn't cause similar problems on
the 1.0.x branch...

Comment 6

[:deanis74]

Comment on attachment 197948 [details] [diff] [review]
310480-context-menu-submenus-fix.patch

GetIsContextMenu() only needs to be called if ctxMenu is not null.

Comment 7

[kguru]

This also is impacting the Thunderbird 1.8 nightlies from 9/29 onwards.  Menus
only appear after a click instead of a mouseover.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in on trunk with Dean's comment incorporated.. can someone verify on
trunk before I request 1.8b5 approval?

Comment 9

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050930
Firefox/1.6a1 ID:2005093011

Looks good to me. Don't see any obvious regressions, but I'm really not sure
what they'd be in this case.

Comment 10

[Asa Dotzler [:asa]]

Verified on latest tinderbox trunk build on win2K and winXP. This is fixed. I
also poked around all of the places we do context menus and didn't see any
regressions.

Comment 11

[Scott MacGregor]

Comment on attachment 197948 [details] [diff] [review]
310480-context-menu-submenus-fix.patch

aproving for the branch now that we've gotten our trunk verification. Please
get this in today if you can. Thanks!

Comment 12

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in on branch.

Comment 13

[Asaf Romano (gone)]

looks good on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20051001
Firefox/1.4.1